From: Thomas Gleixner <tglx@linutronix.de>
To: John Kacur <jkacur@redhat.com>
Cc: rt-users <linux-rt-users@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PREEMPT_RT_FULL Build error fix
Date: Thu, 1 Sep 2011 21:14:42 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109012112100.2723@ionos> (raw)
In-Reply-To: <1314360393-13605-1-git-send-email-jkacur@redhat.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 651 bytes --]
On Fri, 26 Aug 2011, John Kacur wrote:
> Problem:
> make O=/bld/3.0.3-rt11/ kernel/fork.o
> /home/jkacur/jk-2.6/kernel/fork.c:91: error: section of ‘name’ conflicts with previous declaration
>
> __cacheline_aligned is already part of the definition of DEFINE_RWLOCK
> for -rt
>
> However it is not always used for the tasklist_lock in non-rt, so it can't
> simply be added to the definition of DEFINE_RWLOCK in non-rt, so I modified
> the definition in fork.c
-ENOPARSE
The real question is whether RWLOCKS should be cacheline aligned in
general or the RT addon is just overkill. Slapping an ifdef around
does not answer that.
Thanks,
tglx
next prev parent reply other threads:[~2011-09-01 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 12:06 [PATCH] PREEMPT_RT_FULL Build error fix John Kacur
2011-09-01 19:14 ` Thomas Gleixner [this message]
2011-09-06 9:25 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1109012112100.2723@ionos \
--to=tglx@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox