linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ANNOUNCE] 3.2.9-rt15
@ 2012-03-02 17:01 Thomas Gleixner
  2012-03-05 22:14 ` Steven Rostedt
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2012-03-02 17:01 UTC (permalink / raw)
  To: LKML; +Cc: linux-rt-users

Dear RT Folks,

I'm pleased to announce the 3.2.9-rt15 release. There have been a few
not announced intermediate releases which are mostly updates to the
stable tree.

Changes vs. 3.2.9-rt14:

  * seqlock/seqcount live lock fixes 

    	This is a rather massive change, which fixes live locks in the
    	fs code and elsewhere.

  * acpi raw spinlock annotations reverted

    	The raw spinlock conversions cause trouble in the ACPI
    	interrupt handler code and we have no idea why we did that
    	conversion in the first place :(

	So with this revert we hopefully get reports for the initial
	problem so we can look at that for a less problematic fix.

  * Hotplug fixes [Steven Rostedt]

    	This is most of the series Steven posted yesterday. I left out
    	the hotplug core changes as we really need to come up with a
    	less ugly solution for that.
  
  * Futex deadlock fix [Steven Rostedt]

  * Ringbuffer irq disabled check [Steven Rostedt]
	
  * Scheduler state check fix [Steven Rostedt]


The incremental patch against 3.2.9-rt14 can be found here:

  http://www.kernel.org/pub/linux/kernel/projects/rt/3.2/incr/patch-3.2.9-rt14-rt15.patch.xz


The RT patch against 3.2.9 can be found here:

  http://www.kernel.org/pub/linux/kernel/projects/rt/3.2/patch-3.2.9-rt15.patch.xz


The split quilt queue is available at:

  http://www.kernel.org/pub/linux/kernel/projects/rt/3.2/patches-3.2.9-rt15.tar.xz


Enjoy,

	tglx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ANNOUNCE] 3.2.9-rt15
  2012-03-02 17:01 [ANNOUNCE] 3.2.9-rt15 Thomas Gleixner
@ 2012-03-05 22:14 ` Steven Rostedt
  2012-03-06  4:15   ` Fernando Lopez-Lezcano
  2012-03-06  8:20   ` Thomas Gleixner
  0 siblings, 2 replies; 4+ messages in thread
From: Steven Rostedt @ 2012-03-05 22:14 UTC (permalink / raw)
  To: Thomas Gleixner
  Cc: LKML, linux-rt-users, Clark Williams, Luis Claudio R. Goncalves,
	Fernando Lopez-Lezcano

Thomas,

Please fold this change into

   cpu-rt-make-hotplug-lock-a-sleeping-spinlock-on-rt.patch


As the patch was never tested (nor even compiled) it introduced a nasty
bug into taking a CPU down instead of fixing one.

Thanks,

-- Steve

diff --git a/kernel/cpu.c b/kernel/cpu.c
index c25b5ff..66dfb74 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -59,16 +59,20 @@ static struct {
 	int refcount;
 } cpu_hotplug = {
 	.active_writer = NULL,
+#ifdef CONFIG_PREEMPT_RT_FULL
+	.lock = __SPIN_LOCK_UNLOCKED(cpu_hotplug.lock),
+#else
 	.lock = __MUTEX_INITIALIZER(cpu_hotplug.lock),
+#endif
 	.refcount = 0,
 };
 
 #ifdef CONFIG_PREEMPT_RT_FULL
-# define hotplug_lock() spin_lock(&cpu_hotplug.lock)
-# define hotplug_unlock() spin_unlock(&cpu_hotplug.lock)
+# define hotplug_lock() rt_spin_lock(&cpu_hotplug.lock)
+# define hotplug_unlock() rt_spin_unlock(&cpu_hotplug.lock)
 #else
 # define hotplug_lock() mutex_lock(&cpu_hotplug.lock)
-# define hotplug_lock() mutex_unlock(&cpu_hotplug.lock)
+# define hotplug_unlock() mutex_unlock(&cpu_hotplug.lock)
 #endif
 
 struct hotplug_pcp {



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [ANNOUNCE] 3.2.9-rt15
  2012-03-05 22:14 ` Steven Rostedt
@ 2012-03-06  4:15   ` Fernando Lopez-Lezcano
  2012-03-06  8:20   ` Thomas Gleixner
  1 sibling, 0 replies; 4+ messages in thread
From: Fernando Lopez-Lezcano @ 2012-03-06  4:15 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Thomas Gleixner, LKML, linux-rt-users, Clark Williams,
	Luis Claudio R. Goncalves, Fernando Lopez-Lezcano

On 03/05/2012 02:14 PM, Steven Rostedt wrote:
> Thomas,
>
> Please fold this change into
>
>     cpu-rt-make-hotplug-lock-a-sleeping-spinlock-on-rt.patch

Thanks, this fixed the panic on shutdown I was experiencing!
-- Fernando


> As the patch was never tested (nor even compiled) it introduced a nasty
> bug into taking a CPU down instead of fixing one.
>
> Thanks,
>
> -- Steve
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index c25b5ff..66dfb74 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -59,16 +59,20 @@ static struct {
>   	int refcount;
>   } cpu_hotplug = {
>   	.active_writer = NULL,
> +#ifdef CONFIG_PREEMPT_RT_FULL
> +	.lock = __SPIN_LOCK_UNLOCKED(cpu_hotplug.lock),
> +#else
>   	.lock = __MUTEX_INITIALIZER(cpu_hotplug.lock),
> +#endif
>   	.refcount = 0,
>   };
>
>   #ifdef CONFIG_PREEMPT_RT_FULL
> -# define hotplug_lock() spin_lock(&cpu_hotplug.lock)
> -# define hotplug_unlock() spin_unlock(&cpu_hotplug.lock)
> +# define hotplug_lock() rt_spin_lock(&cpu_hotplug.lock)
> +# define hotplug_unlock() rt_spin_unlock(&cpu_hotplug.lock)
>   #else
>   # define hotplug_lock() mutex_lock(&cpu_hotplug.lock)
> -# define hotplug_lock() mutex_unlock(&cpu_hotplug.lock)
> +# define hotplug_unlock() mutex_unlock(&cpu_hotplug.lock)
>   #endif
>
>   struct hotplug_pcp {
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ANNOUNCE] 3.2.9-rt15
  2012-03-05 22:14 ` Steven Rostedt
  2012-03-06  4:15   ` Fernando Lopez-Lezcano
@ 2012-03-06  8:20   ` Thomas Gleixner
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2012-03-06  8:20 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: LKML, linux-rt-users, Clark Williams, Luis Claudio R. Goncalves,
	Fernando Lopez-Lezcano

On Mon, 5 Mar 2012, Steven Rostedt wrote:

> Thomas,
> 
> Please fold this change into
> 
>    cpu-rt-make-hotplug-lock-a-sleeping-spinlock-on-rt.patch
> 
> 
> As the patch was never tested (nor even compiled) it introduced a nasty
> bug into taking a CPU down instead of fixing one.

Grr. I noticed that and fricking forgot to fix it :(

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-03-06  8:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 17:01 [ANNOUNCE] 3.2.9-rt15 Thomas Gleixner
2012-03-05 22:14 ` Steven Rostedt
2012-03-06  4:15   ` Fernando Lopez-Lezcano
2012-03-06  8:20   ` Thomas Gleixner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).