* support compilation with hardening flags
@ 2012-09-02 19:46 Uwe Kleine-König
2012-10-15 23:03 ` John Kacur
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2012-09-02 19:46 UTC (permalink / raw)
To: linux-rt-users, Clark Williams
For Debian 7.0 (aka wheezy) packages it's recommended to use several
hardening flags, the default on amd64 being:
CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security
CPPFLAGS=-D_FORTIFY_SOURCE=2
LDFLAGS=-Wl,-z,relro
This patch doesn't fix all warnings but at least makes all programs compile
again by not using char *variables as printf format strings.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
src/pmqtest/pmqtest.c | 4 ++--
src/ptsematest/ptsematest.c | 4 ++--
src/sigwaittest/sigwaittest.c | 4 ++--
src/svsematest/svsematest.c | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
--- a/src/ptsematest/ptsematest.c
+++ b/src/ptsematest/ptsematest.c
@@ -389,12 +389,12 @@
(int) ((receiver[i].sumdiff / receiver[i].samples) + 0.5),
receiver[i].maxdiff);
if (receiver[i].error[0] != '\0') {
- printf(receiver[i].error);
+ printf("%s", receiver[i].error);
errorlines++;
receiver[i].error[0] = '\0';
}
if (sender[i].error[0] != '\0') {
- printf(sender[i].error);
+ printf("%s", sender[i].error);
errorlines++;
receiver[i].error[0] = '\0';
}
--- a/src/sigwaittest/sigwaittest.c
+++ b/src/sigwaittest/sigwaittest.c
@@ -561,12 +561,12 @@
receiver[i].samples) + 0.5),
receiver[i].maxdiff);
if (receiver[i].error[0] != '\0') {
- printf(receiver[i].error);
+ printf("%s", receiver[i].error);
receiver[i].error[0] = '\0';
errorlines++;
}
if (sender[i].error[0] != '\0') {
- printf(sender[i].error);
+ printf("%s", sender[i].error);
sender[i].error[0] = '\0';
errorlines++;
}
--- a/src/svsematest/svsematest.c
+++ b/src/svsematest/svsematest.c
@@ -646,12 +646,12 @@
receiver[i].samples) + 0.5),
receiver[i].maxdiff);
if (receiver[i].error[0] != '\0') {
- printf(receiver[i].error);
+ printf("%s", receiver[i].error);
receiver[i].error[0] = '\0';
errorlines++;
}
if (sender[i].error[0] != '\0') {
- printf(sender[i].error);
+ printf("%s", sender[i].error);
sender[i].error[0] = '\0';
errorlines++;
}
--- a/src/pmqtest/pmqtest.c
+++ b/src/pmqtest/pmqtest.c
@@ -512,12 +512,12 @@
(int) ((receiver[i].sumdiff / receiver[i].samples) + 0.5),
receiver[i].maxdiff);
if (receiver[i].error[0] != '\0') {
- printf(receiver[i].error);
+ printf("%s", receiver[i].error);
errorlines++;
receiver[i].error[0] = '\0';
}
if (sender[i].error[0] != '\0') {
- printf(sender[i].error);
+ printf("%s", sender[i].error);
errorlines++;
receiver[i].error[0] = '\0';
}
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: support compilation with hardening flags
2012-09-02 19:46 support compilation with hardening flags Uwe Kleine-König
@ 2012-10-15 23:03 ` John Kacur
0 siblings, 0 replies; 2+ messages in thread
From: John Kacur @ 2012-10-15 23:03 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-rt-users, Clark Williams
[-- Attachment #1: Type: TEXT/PLAIN, Size: 3319 bytes --]
This is a good patch, but once again your subject line and description
kinda sucks. I'm fixing it up
Signed-off-by: John Kacur <jkacur@redhat.com>
On Sun, 2 Sep 2012, Uwe Kleine-König wrote:
> For Debian 7.0 (aka wheezy) packages it's recommended to use several
> hardening flags, the default on amd64 being:
>
> CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security
> CPPFLAGS=-D_FORTIFY_SOURCE=2
> LDFLAGS=-Wl,-z,relro
>
> This patch doesn't fix all warnings but at least makes all programs compile
> again by not using char *variables as printf format strings.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> src/pmqtest/pmqtest.c | 4 ++--
> src/ptsematest/ptsematest.c | 4 ++--
> src/sigwaittest/sigwaittest.c | 4 ++--
> src/svsematest/svsematest.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> --- a/src/ptsematest/ptsematest.c
> +++ b/src/ptsematest/ptsematest.c
> @@ -389,12 +389,12 @@
> (int) ((receiver[i].sumdiff / receiver[i].samples) + 0.5),
> receiver[i].maxdiff);
> if (receiver[i].error[0] != '\0') {
> - printf(receiver[i].error);
> + printf("%s", receiver[i].error);
> errorlines++;
> receiver[i].error[0] = '\0';
> }
> if (sender[i].error[0] != '\0') {
> - printf(sender[i].error);
> + printf("%s", sender[i].error);
> errorlines++;
> receiver[i].error[0] = '\0';
> }
> --- a/src/sigwaittest/sigwaittest.c
> +++ b/src/sigwaittest/sigwaittest.c
> @@ -561,12 +561,12 @@
> receiver[i].samples) + 0.5),
> receiver[i].maxdiff);
> if (receiver[i].error[0] != '\0') {
> - printf(receiver[i].error);
> + printf("%s", receiver[i].error);
> receiver[i].error[0] = '\0';
> errorlines++;
> }
> if (sender[i].error[0] != '\0') {
> - printf(sender[i].error);
> + printf("%s", sender[i].error);
> sender[i].error[0] = '\0';
> errorlines++;
> }
> --- a/src/svsematest/svsematest.c
> +++ b/src/svsematest/svsematest.c
> @@ -646,12 +646,12 @@
> receiver[i].samples) + 0.5),
> receiver[i].maxdiff);
> if (receiver[i].error[0] != '\0') {
> - printf(receiver[i].error);
> + printf("%s", receiver[i].error);
> receiver[i].error[0] = '\0';
> errorlines++;
> }
> if (sender[i].error[0] != '\0') {
> - printf(sender[i].error);
> + printf("%s", sender[i].error);
> sender[i].error[0] = '\0';
> errorlines++;
> }
> --- a/src/pmqtest/pmqtest.c
> +++ b/src/pmqtest/pmqtest.c
> @@ -512,12 +512,12 @@
> (int) ((receiver[i].sumdiff / receiver[i].samples) + 0.5),
> receiver[i].maxdiff);
> if (receiver[i].error[0] != '\0') {
> - printf(receiver[i].error);
> + printf("%s", receiver[i].error);
> errorlines++;
> receiver[i].error[0] = '\0';
> }
> if (sender[i].error[0] != '\0') {
> - printf(sender[i].error);
> + printf("%s", sender[i].error);
> errorlines++;
> receiver[i].error[0] = '\0';
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-15 23:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-02 19:46 support compilation with hardening flags Uwe Kleine-König
2012-10-15 23:03 ` John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).