From: Thomas Gleixner <tglx@linutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
pjt@google.com, paul.mckenney@linaro.org, tj@kernel.org,
mingo@redhat.com, peterz@infradead.org, Arvind.Chauhan@arm.com,
linaro-dev@lists.linaro.org, patches@linaro.org,
pdsw-power-team@arm.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH V2 Resend 4/4] timer: Migrate running timer
Date: Mon, 13 May 2013 12:35:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1305131223470.2863@ionos> (raw)
In-Reply-To: <CAKohpo=eAGVA540jN8+t0aaqCV9qJRkH0q9-q6QVUYusWQqSYw@mail.gmail.com>
On Mon, 13 May 2013, Viresh Kumar wrote:
> On 24 April 2013 16:52, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 9 April 2013 20:22, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >> [Steven replied to a personal Ping!!, including everybody again]
> >>
> >> On 9 April 2013 19:25, Steven Rostedt <rostedt@goodmis.org> wrote:
> >>> On Tue, 2013-04-09 at 14:05 +0530, Viresh Kumar wrote:
> >>>> Ping!!
> >>>>
> >>>
> >>> Remind me again. What problem are you trying to solve?
> >>
> >> I was trying to migrate a running timer which arms itself, so that we don't
> >> keep a cpu busy just for servicing this timer.
Which mechanism is migrating the timer away?
> >>>> On 20 March 2013 20:43, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >>>> >
> >>>> > Hi Steven/Thomas,
> >>>> >
> >>>> > I came back to this patch after completing some other stuff and posting
> >>>> > wq part of this patchset separately.
> >>>> >
> >>>> > I got your point and understand how this would fail.
> >>>> >
> >>>> > @Thomas: I need your opinion first. Do you like this concept of migrating
> >>>> > running timer or not? Or you see some basic problem with this concept?
I have no objections to the functionality per se, but the proposed
solution is not going to fly.
Aside of bloating the data structure you're changing the semantics of
__mod_timer(). No __mod_timer() caller can deal with -EBUSY. So you'd
break the world and some more.
Here is a list of questions:
- Which mechanism migrates timers?
- How is that mechanism triggered?
- How does that deal with CPU bound timers?
Thanks,
tglx
next prev parent reply other threads:[~2013-05-13 10:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 10:34 [PATCH V2 Resend 0/4] Create sched_select_cpu() and use it for workqueues and timers Viresh Kumar
2012-11-06 10:38 ` [PATCH V2 Resend 3/4] workqueue: Schedule work on non-idle cpu instead of current one Viresh Kumar
[not found] ` <ad25c731a6ca1bd1269555245952f05c856a9759.1352196505.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-11-26 17:15 ` Tejun Heo
2012-11-27 5:19 ` Viresh Kumar
2012-11-27 12:54 ` Vincent Guittot
[not found] ` <CAKohpom9=K976NmyFWtXx2UQyRcLAqsoGw-5AaqXRpSL6uxP_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-04 11:11 ` Viresh Kumar
2013-01-04 15:09 ` Tejun Heo
2013-01-07 9:58 ` Viresh Kumar
2013-01-07 13:28 ` Steven Rostedt
2013-01-07 17:59 ` Viresh Kumar
2013-01-07 22:29 ` Steven Rostedt
2013-01-08 4:03 ` Viresh Kumar
2013-01-07 15:04 ` Tejun Heo
2013-01-07 15:40 ` Amit Kucheria
2013-01-07 18:07 ` Viresh Kumar
2013-01-09 18:49 ` Tejun Heo
2013-01-10 5:04 ` Viresh Kumar
2012-11-27 13:26 ` Steven Rostedt
2012-11-27 13:48 ` Viresh Kumar
2012-11-27 13:59 ` Steven Rostedt
2012-11-27 14:55 ` Vincent Guittot
2012-11-27 15:04 ` Steven Rostedt
2012-11-27 15:35 ` Vincent Guittot
[not found] ` <cover.1352196505.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-11-06 10:38 ` [PATCH V2 Resend 1/4] sched: Create sched_select_cpu() to give preferred CPU for power saving Viresh Kumar
2012-11-06 10:38 ` [PATCH V2 Resend 2/4] timer: hrtimer: Don't check idle_cpu() before calling get_nohz_timer_target() Viresh Kumar
2012-11-06 10:38 ` [PATCH V2 Resend 4/4] timer: Migrate running timer Viresh Kumar
2012-11-27 13:47 ` Steven Rostedt
2013-03-20 15:13 ` Viresh Kumar
2013-04-09 14:52 ` Viresh Kumar
2013-04-24 11:22 ` Viresh Kumar
2013-05-13 9:19 ` Viresh Kumar
2013-05-13 10:35 ` Thomas Gleixner [this message]
2013-05-22 8:34 ` Viresh Kumar
2013-05-22 9:06 ` Peter Zijlstra
2013-05-22 9:23 ` Viresh Kumar
2013-05-31 10:49 ` Viresh Kumar
2013-06-18 4:51 ` Viresh Kumar
2013-07-24 9:17 ` Viresh Kumar
2013-08-07 9:55 ` Viresh Kumar
2013-10-04 12:39 ` Sebastian Andrzej Siewior
2013-10-23 5:55 ` Viresh Kumar
2012-11-26 15:00 ` [PATCH V2 Resend 0/4] Create sched_select_cpu() and use it for workqueues and timers Viresh Kumar
2012-11-26 16:40 ` Steven Rostedt
[not found] ` <1353948027.6276.38.camel-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2012-11-26 17:03 ` Paul E. McKenney
2012-11-26 17:35 ` Steven Rostedt
[not found] ` <1353951352.6276.43.camel-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2012-11-26 19:03 ` Paul E. McKenney
2012-11-26 19:17 ` Steven Rostedt
2012-11-27 6:25 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1305131223470.2863@ionos \
--to=tglx@linutronix.de \
--cc=Arvind.Chauhan@arm.com \
--cc=johnstul@us.ibm.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patches@linaro.org \
--cc=paul.mckenney@linaro.org \
--cc=pdsw-power-team@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).