Re: [PATCH] cyclictest: white space cleanup

[John Kacur <jkacur@redhat.com>]

On Mon, 28 Jan 2013, Frank Rowand wrote:

> On 01/28/13 18:09, Frank Rowand wrote:
> > Clean up cyclictest formatting:
> >   Change leading spaces to tabs.
> >   Align function parameters.
> >   Place type of function on same line as function name.
> > 
> > Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
> > ---
> >  src/cyclictest/cyclictest.c |   43 	21 +	22 -	0 !
> >  1 file changed, 21 insertions(+), 22 deletions(-)
> > 
> 
> < snip >
> 
> The motivation of the white space clean up is so that future
> patches will not add white space damage.  Many editors will
> automatically copy the bad white space if a line immediately
> following is added.
> 
> I tried to not get carried away with other formatting clean
> up.  The alignment of function parameters was only a few
> locations and seemed in the spirit of white space clean up.
> 
> The "type of function name" fix was getting carried away, but
> there was only one instance so I don't feel too guilty.
> 

Okay, this is fine. Whitespace patches can be annoying though when they 
cause conflicts, I had to apply this before patches from Bhavesh Davda
but I understand your motivation.

Applied and in my devel repo to be pushed to Clark

Thanks