linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: anna-maria@glx-um.de
Cc: linux-rt-users@vger.kernel.org, Clark Williams <williams@redhat.com>
Subject: Re: [patch 2/3] cyclictest: Convert the offset of the alignment option to microseconds
Date: Wed, 27 May 2015 23:32:21 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.10.1505272324180.13094@riemann> (raw)
In-Reply-To: <20150526190443.640221319@glx-um.de>



On Tue, 26 May 2015, anna-maria@glx-um.de wrote:

> The offset is specified in microseconds according to the
> documentation, but, the microseconds to nanoseconds conversion is
> missing so the effective offset has the unit of nanoseconds.
> 
> Signed-off-by: Anna-Maria Gleixner <anna-maria@glx-um.de>
> ---
>  src/cyclictest/cyclictest.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: rt-tests/src/cyclictest/cyclictest.c
> ===================================================================
> --- rt-tests.orig/src/cyclictest/cyclictest.c
> +++ rt-tests/src/cyclictest/cyclictest.c
> @@ -1289,7 +1289,7 @@ static void process_options (int argc, c
>  		case OPT_ALIGNED:
>  			aligned=1;
>  			if (optarg != NULL)
> -				offset = atoi(optarg);
> +				offset = atoi(optarg) * 1000;
>  			else if (optind<argc && atoi(argv[optind])

Don't we need the conversion here too then?
>  				offset = atoi(argv[optind]);

>  			else
> 
> 
> --

Thanks

John

  reply	other threads:[~2015-05-27 21:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 19:06 [patch 0/3] cyclictest: Various fixes and a new option anna-maria
2015-05-26 19:07 ` [patch 1/3] cyclictest: Ensure that next wakeup time is never in the past anna-maria
2015-06-02 13:06   ` John Kacur
2015-05-26 19:07 ` [patch 2/3] cyclictest: Convert the offset of the alignment option to microseconds anna-maria
2015-05-27 21:32   ` John Kacur [this message]
2015-05-30 11:01     ` Anna-Maria Gleixner
2015-06-02 13:00       ` John Kacur
2015-06-02 21:01         ` Thomas Gleixner
2015-06-02 21:17           ` John Kacur
2015-06-02 21:33             ` Thomas Gleixner
2015-06-08 13:18               ` Anna-Maria Gleixner
2015-06-08 17:31                 ` John Kacur
2015-05-26 19:07 ` [patch 3/3] cyclictest: Align measurement threads to the next full second anna-maria
2015-05-30 11:02   ` Anna-Maria Gleixner
2015-06-02 13:05     ` John Kacur
2015-06-08 13:21       ` Anna-Maria Gleixner
2015-06-08 17:32         ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.10.1505272324180.13094@riemann \
    --to=jkacur@redhat.com \
    --cc=anna-maria@glx-um.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).