From: John Kacur <jkacur@redhat.com>
To: Henrik Austad <haustad@cisco.com>
Cc: Clark Williams <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
linux-rt-users@vger.kernel.org, Josh Cartwright <joshc@ni.com>
Subject: Re: [PATCH 5/6] Makefile: add librttest to rt-migrate-test
Date: Mon, 21 Sep 2015 21:52:55 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.20.1509212151560.12009@riemann> (raw)
In-Reply-To: <1442849248-573-6-git-send-email-haustad@cisco.com>
On Mon, 21 Sep 2015, Henrik Austad wrote:
> linker must be able to resolve reference to err_msg_n properly
>
> rt-migrate-test.c:(.text+0x1ff): undefined reference to `err_msg_n'
>
> Signed-off-by: Henrik Austad <haustad@cisco.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index fcf20ce..66de743 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -87,8 +87,8 @@ hwlatdetect: src/hwlatdetect/hwlatdetect.py
> chmod +x src/hwlatdetect/hwlatdetect.py
> ln -s src/hwlatdetect/hwlatdetect.py hwlatdetect
>
> -rt-migrate-test: rt-migrate-test.o
> - $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS)
> +rt-migrate-test: rt-migrate-test.o librttest.a
> + $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) $(RTTESTLIB)
>
> ptsematest: ptsematest.o librttest.a
> $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $< $(LIBS) $(RTTESTLIB) $(EXTRA_LIBS)
> --
Ah, I see, this patch fixes the compile error that the previous patch
introduces. So, you at least need to reorder them.
I'm accepting this patch for now, but I think some time is necessary to
review the previous patch.
Signed-off-by: John Kacur <jkacur@redhat.com>
>
next prev parent reply other threads:[~2015-09-21 19:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 15:27 [PATCH 0/6] RFC v2: add support for tilegx and (partial) android support to rt-test Henrik Austad
2015-09-21 15:27 ` [PATCH 1/6] Add CROSS_COMPILE-switch to CC and AR Henrik Austad
2015-09-21 19:41 ` John Kacur
2015-09-21 15:27 ` [PATCH 2/6] Add syscall-number for sched_(gs)etattr() for tile Henrik Austad
2015-09-21 19:42 ` John Kacur
2015-09-21 15:27 ` [PATCH 3/6] Add a rebuild-switch to Makefile Henrik Austad
2015-09-21 19:43 ` John Kacur
2015-09-21 15:27 ` [PATCH 4/6] Fix compile-warnings Henrik Austad
2015-09-21 19:49 ` John Kacur
2015-09-21 15:27 ` [PATCH 5/6] Makefile: add librttest to rt-migrate-test Henrik Austad
2015-09-21 19:52 ` John Kacur [this message]
2015-09-22 10:06 ` Henrik Austad
2015-09-21 15:27 ` [PATCH 6/6] android: adjust target for android Henrik Austad
2015-09-21 20:00 ` John Kacur
2015-09-22 10:08 ` Henrik Austad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1509212151560.12009@riemann \
--to=jkacur@redhat.com \
--cc=haustad@cisco.com \
--cc=joshc@ni.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).