linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: linux-rt-users@vger.kernel.org, williams@redhat.com
Subject: Re: [RFC 0/4] cyclictest: improve running under trace-cmd
Date: Wed, 24 Feb 2016 18:08:58 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.20.1602241802300.13215@riemann> (raw)
In-Reply-To: <1456256633-17639-1-git-send-email-lcapitulino@redhat.com>



On Tue, 23 Feb 2016, Luiz Capitulino wrote:

> 
> In short, this series allows you to run cyclictest under
> trace-cmd and still get trace marks when the latency
> specified with -b is execeded. More details in patch 4/4.
> 
> This series is RFC because I'm not completely sure this
> is the right thing to do. I'm wondering if we shouldn't
> ditch all tracing support from cyclictest...
> 
> Luiz Capitulino (4):
>   cyclictest: tracing(): check for notrace
>   cyclictest: move debugfs init code to its own function
>   cyclictest: move tracemark_fd handling to its own function
>   cyclictest: add --tracemark option
> 
>  src/cyclictest/cyclictest.c | 62 ++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 47 insertions(+), 15 deletions(-)
> 
> -- 

Hi. First of all, although I didn't look closely at the details yet, I 
like this set of patches. Just to let you and everyone else know where we 
are, Clark and I are going to put rt-tests into maintainence mode very 
shortly. We want to create a 1.0 version of it, which we will maintain 
with fixes, but no new features. This last set of patches would be a nice 
addition before we go into mainatinence mode so that the old code base 
would have a way of using trace-cmd.

For the next development line of rt-tests, we would like to rip-out all of 
the tracing code that we can, and leave the bare minimum in place to 
interact with trace-cmd. With that in mind, could you go over your RFC 
patches, and if you are satisfied that they don't break anything, but 
allow tracing under trace-cmd, then this could be the last new feature we 
let in. Let me know and I'll review at that point. I'll make and official 
announcement about maintainence mode and a new development line in a 
separate mail as well.

Thank You!

John Kacur

  parent reply	other threads:[~2016-02-24 17:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 19:43 [RFC 0/4] cyclictest: improve running under trace-cmd Luiz Capitulino
2016-02-23 19:43 ` [RFC 1/4] cyclictest: tracing(): check for notrace Luiz Capitulino
2016-02-23 19:43 ` [RFC 2/4] cyclictest: move debugfs init code to its own function Luiz Capitulino
2016-02-23 19:43 ` [RFC 3/4] cyclictest: move tracemark_fd handling " Luiz Capitulino
2016-02-23 19:43 ` [RFC 4/4] cyclictest: add --tracemark option Luiz Capitulino
2016-02-24 17:08 ` John Kacur [this message]
2016-02-24 17:56   ` [RFC 0/4] cyclictest: improve running under trace-cmd Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1602241802300.13215@riemann \
    --to=jkacur@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).