Re: [PATCH 1/4] cyclictest: tracing(): check for notrace

[John Kacur <jkacur@redhat.com>]

On Thu, 17 Mar 2016, Luiz Capitulino wrote:

> If you pass -b and --notrace to cyclictest today, it will
> write to tracing_on when -b latency is reached.
> 
> Fix this by making tracing() check notrace.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  src/cyclictest/cyclictest.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index f5a67dc..6070457 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -479,6 +479,9 @@ static void tracemark(char *fmt, ...)
>  
>  static void tracing(int on)
>  {
> +	if (notrace)
> +		return;
> +
>  	if (on) {
>  		switch (kernelversion) {
>  		case KV_26_LT18: gettimeofday(0,(struct timezone *)1); break;
> @@ -1698,7 +1701,7 @@ static void sighand(int sig)
>  	shutdown = 1;
>  	if (refresh_on_max)
>  		pthread_cond_signal(&refresh_on_max_cond);
> -	if (tracelimit && !notrace)
> +	if (tracelimit)
>  		tracing(0);
>  }
>  
> @@ -2303,7 +2306,7 @@ int main(int argc, char **argv)
>  	}
>   out:
>  	/* ensure that the tracer is stopped */
> -	if (tracelimit && !notrace)
> +	if (tracelimit)
>  		tracing(0);
>  
>  
> -- 
> 2.1.0
> 
> --
Signed-off-by: John Kacur <jkacur@redhat.com>