linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: linux-rt-users@vger.kernel.org, williams@redhat.com
Subject: Re: [PATCH 2/4] cyclictest: move debugfs init code to its own function
Date: Tue, 22 Mar 2016 15:40:27 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.20.1603221540080.10687@riemann> (raw)
In-Reply-To: <1458239417-31089-3-git-send-email-lcapitulino@redhat.com>



On Thu, 17 Mar 2016, Luiz Capitulino wrote:

> A function added by a future commit will want to call
> this code too.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  src/cyclictest/cyclictest.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 6070457..4e80831 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -514,11 +514,8 @@ static int settracer(char *tracer)
>  	return -1;
>  }
>  
> -static void setup_tracer(void)
> +static void debugfs_prepare(void)
>  {
> -	if (!tracelimit || notrace)
> -		return;
> -
>  	if (mount_debugfs(NULL))
>  		fatal("could not mount debugfs");
>  
> @@ -533,6 +530,14 @@ static void setup_tracer(void)
>  			    "TRACERs not configured?\n", testname);
>  	} else
>  		fileprefix = procfileprefix;
> +}
> +
> +static void setup_tracer(void)
> +{
> +	if (!tracelimit || notrace)
> +		return;
> +
> +	debugfs_prepare();
>  
>  	if (kernelversion >= KV_26_33) {
>  		int ret;
> -- 
> 2.1.0
> 
> --

Signed-off-by: John Kacur <jkacur@redhat.com>

  reply	other threads:[~2016-03-22 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 18:30 [PATCH v2 0/4] cyclictest: improve running under trace-cmd Luiz Capitulino
2016-03-17 18:30 ` [PATCH 1/4] cyclictest: tracing(): check for notrace Luiz Capitulino
2016-03-22 14:37   ` John Kacur
2016-03-17 18:30 ` [PATCH 2/4] cyclictest: move debugfs init code to its own function Luiz Capitulino
2016-03-22 14:40   ` John Kacur [this message]
2016-03-17 18:30 ` [PATCH 3/4] cyclictest: move tracemark_fd handling " Luiz Capitulino
2016-03-22 14:35   ` John Kacur
2016-03-22 14:42     ` Luiz Capitulino
2016-03-17 18:30 ` [PATCH 4/4] cyclictest: add --tracemark option Luiz Capitulino
2016-03-22 14:57   ` John Kacur
2016-03-22 15:01     ` Luiz Capitulino
  -- strict thread matches above, loose matches on Subject: below --
2016-02-25 16:29 [PATCH 0/4] cyclictest: improve running under trace-cmd Luiz Capitulino
2016-02-25 16:29 ` [PATCH 2/4] cyclictest: move debugfs init code to its own function Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1603221540080.10687@riemann \
    --to=jkacur@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).