From: John Kacur <jkacur@redhat.com>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Clark Williams <williams@redhat.com>, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] cyclictest: new CPUs with SMI counter support
Date: Tue, 31 May 2016 10:47:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.20.1605311043460.6356@riemann.home> (raw)
In-Reply-To: <8cbc61e6bb66eaca972e9697ae38c4d23e193e09.1464644578.git.bristot@redhat.com>
On Mon, 30 May 2016, Daniel Bristot de Oliveira wrote:
> Cyclictest's SMI counter implementation is based on turbostat's
> implementation. This patch syncs cyclictest's has_smi_counter()
> with turbostat's check.
>
> From turbostat's commits:
> cdc5727 tools/power turbostat: initial KBL support
> ec53e59 tools/power turbostat: initial SKX support
> e4085d5 tools/power turbostat: initial BXT support
>
> [ John & Clark, I did it in the branch devel/v2.0, but we need ]
> [ this in the 0.x and 1.x series as well. ]
>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> ---
> src/cyclictest/cyclictest.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 00e5f3d..5e23fc5 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -927,10 +927,14 @@ static int has_smi_counter(void)
> case 0x56: /* BDX-DE */
> case 0x4E: /* SKL */
> case 0x5E: /* SKL */
> + case 0x8E: /* KBL */
> + case 0x9E: /* KBL */
> + case 0x55: /* SKX */
> case 0x37: /* BYT */
> case 0x4D: /* AVN */
> case 0x4C: /* AMT */
> case 0x57: /* PHI */
> + case 0x5C: /* BXT */
> break;
> default:
> return 0;
> --
I applied the patch to both the stable and devel branches. I slightly
modified the commit message to read.
" Cyclictest's SMI counter implementation is based on the turbostat
tool in the Linux kernel. This patch syncs cyclictest's
has_smi_counter() with turbostat's check.
"
Signed-off-by: John Kacur <jkacur@redhat.com>
next prev parent reply other threads:[~2016-05-31 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 22:25 [PATCH] cyclictest: new CPUs with SMI counter support Daniel Bristot de Oliveira
2016-05-31 8:47 ` John Kacur [this message]
2016-05-31 11:31 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1605311043460.6356@riemann.home \
--to=jkacur@redhat.com \
--cc=bristot@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).