From: John Kacur <jkacur@redhat.com>
To: Tommi Rantala <tommi.t.rantala@nokia.com>
Cc: Clark Williams <williams@redhat.com>, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH 24/34] signaltest: remove unused ARRAY_SIZE macro
Date: Mon, 22 May 2017 18:44:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.20.1705221843320.7915@riemann> (raw)
In-Reply-To: <20170522082540.15467-25-tommi.t.rantala@nokia.com>
On Mon, 22 May 2017, Tommi Rantala wrote:
> Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
> ---
> src/signaltest/signaltest.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/signaltest/signaltest.c b/src/signaltest/signaltest.c
> index 59f979e..72a549d 100644
> --- a/src/signaltest/signaltest.c
> +++ b/src/signaltest/signaltest.c
> @@ -30,8 +30,6 @@
> #include "error.h"
> #include "rt-utils.h"
>
> -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
> -
> /* Ugly, but .... */
> #define gettid() syscall(__NR_gettid)
>
> --
NAK
You're right, it could be removed, but it's not really causing in harm
either. I'm going to leave it in for now.
Thanks
John
next prev parent reply other threads:[~2017-05-22 16:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 8:25 [PATCH 00/34] rt-tests fixes and cleanups Tommi Rantala
2017-05-22 8:25 ` [PATCH 01/34] rt-utils: add cpus_online() helper Tommi Rantala
2017-05-22 8:25 ` [PATCH 02/34] cyclictest: use " Tommi Rantala
2017-05-22 8:25 ` [PATCH 03/34] cyclictest: always clear stop to avoid -Wmaybe-uninitialized warning Tommi Rantala
2017-05-22 8:25 ` [PATCH 04/34] cyclictest: remove extra argument in warn() and fatal() calls Tommi Rantala
2017-05-22 8:25 ` [PATCH 05/34] cyclictest: fix signed vs unsigned compiler warnings Tommi Rantala
2017-05-22 8:25 ` [PATCH 06/34] cyclictest: fix typo in warn() message Tommi Rantala
2017-05-22 15:35 ` John Kacur
2017-05-22 8:25 ` [PATCH 07/34] cyclictest: update --smp help: -n was removed Tommi Rantala
2017-05-22 16:07 ` John Kacur
2017-05-22 8:25 ` [PATCH 08/34] cyclictest: adjust whitespace in display_help() output Tommi Rantala
2017-05-22 16:08 ` John Kacur
2017-05-22 8:25 ` [PATCH 09/34] cyclictest: use %p for printing void*, and print stack size separately Tommi Rantala
2017-05-22 8:25 ` [PATCH 10/34] cyclictest: use %zd for printing size_t in rt_numa_numa_alloc_onnode() Tommi Rantala
2017-05-22 15:25 ` John Kacur
2017-05-22 8:25 ` [PATCH 11/34] cyclictest: max_cpus unused in this variant of rt_numa_parse_cpustring() Tommi Rantala
2017-05-22 8:25 ` [PATCH 12/34] cyclictest: fix off-by-one in clocksel check Tommi Rantala
2017-05-22 16:23 ` John Kacur
2017-05-22 8:25 ` [PATCH 13/34] cyclictest: check timer_getoverrun() return value for failure Tommi Rantala
2017-05-22 8:25 ` [PATCH 14/34] cyclictest: fix MODE_CYCLIC measurement failure after timer overruns Tommi Rantala
2017-05-22 8:25 ` [PATCH 15/34] cyclictest: param is unused in fifothread() Tommi Rantala
2017-05-22 16:29 ` John Kacur
2017-05-22 8:25 ` [PATCH 16/34] cyclictest: normalize next before tsgreater() check Tommi Rantala
2017-05-22 8:25 ` [PATCH 17/34] cyclictest: tsnorm() after adjusting next Tommi Rantala
2017-05-22 8:25 ` [PATCH 18/34] pip_stress: fix missing argument in err_msg() call in process_shared_mutex_available() Tommi Rantala
2017-05-22 16:36 ` John Kacur
2017-05-22 8:25 ` [PATCH 19/34] pip_stress: getopt.h and long_options[] are unused Tommi Rantala
2017-05-22 16:39 ` John Kacur
2017-05-22 8:25 ` [PATCH 20/34] pi_stress: use cpus_online() helper Tommi Rantala
2017-05-22 8:25 ` [PATCH 21/34] pi_stress: use %lu for unsigned long Tommi Rantala
2017-05-22 15:34 ` John Kacur
2017-05-22 8:25 ` [PATCH 22/34] pi_stress: add missing argument in pi_error() call Tommi Rantala
2017-05-22 15:14 ` John Kacur
2017-05-22 8:25 ` [PATCH 23/34] svsematest: test .mindiff against UINT_MAX Tommi Rantala
2017-05-22 15:20 ` John Kacur
2017-05-22 8:25 ` [PATCH 24/34] signaltest: remove unused ARRAY_SIZE macro Tommi Rantala
2017-05-22 16:44 ` John Kacur [this message]
2017-06-05 10:06 ` Tommi Rantala
2017-06-08 14:28 ` John Kacur
2017-05-22 8:25 ` [PATCH 25/34] deadline_test: fix stack corruption in setup_ftrace_marker() Tommi Rantala
2017-05-22 8:25 ` [PATCH 26/34] deadline_test: remove unused tid parameter in do_runtime() Tommi Rantala
2017-05-22 8:25 ` [PATCH 27/34] deadline_test: tv_nsec is long Tommi Rantala
2017-05-22 8:25 ` [PATCH 28/34] deadline_test: use %llu for printing unsigned long longs Tommi Rantala
2017-05-22 8:25 ` [PATCH 29/34] cyclicdeadline: fix stack corruption in setup_ftrace_marker() Tommi Rantala
2017-05-22 9:04 ` [PATCH 30/34] cyclicdeadline: remove unused tid parameter from do_runtime() Tommi Rantala
2017-05-22 9:04 ` [PATCH 31/34] cyclicdeadline: avoid signed vs unsigned compiler warnings Tommi Rantala
2017-05-22 9:04 ` [PATCH 32/34] printf format attributes and format string constness in error helpers Tommi Rantala
2017-05-22 9:04 ` [PATCH 33/34] mark unused sighand() parameters with unused attribute Tommi Rantala
2017-05-22 15:47 ` John Kacur
2017-05-22 9:04 ` [PATCH 34/34] read-only struct option array constness Tommi Rantala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1705221843320.7915@riemann \
--to=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=tommi.t.rantala@nokia.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox