Re: [PATCH] backfire: fix build failure for 4.11+ kernels

[John Kacur <jkacur@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2126 bytes --]



On Wed, 12 Jul 2017, Uwe Kleine-König wrote:

> On Tue, Jul 11, 2017 at 02:44:59PM -0300, Marcelo Henrique Cerri wrote:
> > Since v4.11-rc1~18^2~76, kill_pid() is declared in
> > "linux/sched/signal.h" instead of in "linux/sched.h".
> > 
> > Include the correct header file based on the kernel version to keep
> > it compatible with older kernels.
> > 
> > Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> 
> When talking on irc to Sebastian we thought it a better idea to just
> remove backfire. I patched if already in the past for the debian
> packaging to build on 2.6.32 and 3.6 which were the versions available
> in Debian back then. That also means that the patch in question here
> isn't sufficient to make backfire build on 4.11. In fact it doesn't
> compile since 2.6.39-rc1 when SPIN_LOCK_UNLOCKED was killed in
> d04fa5a3ba06 ("locking: Remove deprecated lock initializers").
> 
> @John and Clark: Which branch do you want me to base a "remove bitrotten
> backfire" patch on? IMHO there is a bit of chaos there because the v1.1
> tag bases on v2.0 and has VERSION = 2.0 in Makefile. stable/v1.0
> bases on v1.0, while unstable/devel/v1.1.1 bases on v1.1 and v1.1.1
> seems to be its target version?
> 
> Best regards
> Uwe

Hmmn, I find the idea of backfire kinda neat, my first instinct is to
say, why can't we fix this? If something is broken in the devel version
too, that's okay with me, you can disable that part if you want to
ship the devel version.

That being said, in a quick chat with Clark, he said he's not using it.
It was written by Carsten I believe.

The naming chaos is my fault, it took my awhile to settle on naming
the devel version. However I wonder if something is wrong with your
local repo, because I thought I had cleaned that all up? I don't
see VERSION = 2.0 in the makefile for example.

Not sure what to do about this. Does your patch for versions below 3.6
actually work, or does it allow you to compile, but it's still broken?
If it is broken, then I guess I would be okay with removing it from
1.0, but leave it in the devel version for now.

Thanks

John