From: John Kacur <jkacur@redhat.com>
To: Daniel Wagner <daniel.wagner@siemens.com>
Cc: linux-rt-users@vger.kernel.org, Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 1/4] cyclicdeadline: Fix stack corruption
Date: Fri, 5 Apr 2019 18:28:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.21.1904051828030.8480@planxty> (raw)
In-Reply-To: <20190312172436.18314-2-daniel.wagner@siemens.com>
On Tue, 12 Mar 2019, Daniel Wagner wrote:
> The buffer is too short for the string.
>
> Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
> ---
> src/sched_deadline/cyclicdeadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
> index 577ad95cfee1..095e6ccc166f 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -285,7 +285,7 @@ static void setup_ftrace_marker(void)
> {
> struct stat st;
> const char *debugfs = find_debugfs();
> - char files[strlen(debugfs) + 14];
> + char files[strlen(debugfs) + strlen("/tracing/trace_marker")];
> int ret;
>
> if (strlen(debugfs) == 0)
> --
> 2.20.1
>
Same here, you were faster than Kurt, but he included the null byte, so I
grabbed his
next prev parent reply other threads:[~2019-04-05 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 17:24 [PATCH 0/4] rt-tests bug fixes Daniel Wagner
2019-03-12 17:24 ` [PATCH 1/4] cyclicdeadline: Fix stack corruption Daniel Wagner
2019-04-05 16:28 ` John Kacur [this message]
2019-03-12 17:24 ` [PATCH 2/4] deadline_test: " Daniel Wagner
2019-04-05 16:27 ` John Kacur
2019-03-12 17:24 ` [PATCH 3/4] deadline_test: Free allocated resources at exit Daniel Wagner
2019-04-05 16:29 ` John Kacur
2019-03-12 17:24 ` [PATCH 4/4] cyclicdeadline: " Daniel Wagner
2019-04-05 16:31 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1904051828030.8480@planxty \
--to=jkacur@redhat.com \
--cc=daniel.wagner@siemens.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox