From: John Kacur <jkacur@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Joe Korty <joe.korty@concurrent-rt.com>,
rt-users <linux-rt-users@vger.kernel.org>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 1/1] rt-tests: ssdd: Add Licence information to ssdd
Date: Mon, 17 Jun 2019 17:05:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.21.1906171705110.10931@planxty> (raw)
In-Reply-To: <20190614193442.wrsbby4jydcoet4c@linutronix.de>
On Fri, 14 Jun 2019, Sebastian Andrzej Siewior wrote:
> On 2019-06-14 13:37:47 [+0200], John Kacur wrote:
> > Add License Information to ssdd
>
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> > src/ssdd/ssdd.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/src/ssdd/ssdd.c b/src/ssdd/ssdd.c
> > index 4e293586526e..2c3a779be9f1 100644
> > --- a/src/ssdd/ssdd.c
> > +++ b/src/ssdd/ssdd.c
> > @@ -15,6 +15,13 @@
> > *
> > * The tracer waits on each PTRACE_SINGLESTEP with a waitpid(2)
> > * and checks that waitpid's return values for correctness.
> > + *
> > + * This program was originally written by
> > + * Joe Korty <joe.korty@concurrent-rt.com>
> > + * This program is free software; you can redistribute it and / or modify
> > + * it under the terms of the GNU General Public License Version 2
> > + * of the licence, or (at your option) any later version
> > + * see COPYING for more information
>
> SPDX tags is not something that you have in rt-tests, right? Because a
> standard tag would be kind of better than having yet another unique
> version of text saying that it is GPLv2-or-later.
>
> So you could reduce this to two lines:
> - // SPDX-License-Identifier: GPL-2.0-or-later
> top
>
> - Author: Joe Korty <joe.korty@concurrent-rt.com>
> Somewhere at top where the comment starts.
>
> > */
> > #include <stdio.h>
> > #include <stdlib.h>
>
> Sebastian
>
Thanks for the tip Sebastian, looks good to me,
I'm looking into doing this.
John
next prev parent reply other threads:[~2019-06-17 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 11:37 [PATCH 0/1] *** Make licence explicit for ssdd *** John Kacur
2019-06-14 11:37 ` [PATCH 1/1] rt-tests: ssdd: Add Licence information to ssdd John Kacur
2019-06-14 19:34 ` Sebastian Andrzej Siewior
2019-06-17 15:05 ` John Kacur [this message]
2019-06-14 13:53 ` [PATCH 0/1] *** Make licence explicit for ssdd *** Joe Korty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1906171705110.10931@planxty \
--to=jkacur@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=joe.korty@concurrent-rt.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox