From: John Kacur <jkacur@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Kurt Kanzenbach <kurt@linutronix.de>,
Clark Williams <williams@redhat.com>,
rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 3/6] rt-tests: deadline: Remove duplicated gettid() code
Date: Tue, 25 Jun 2019 11:29:28 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.21.1906251117160.4274@planxty.home> (raw)
In-Reply-To: <20190624134045.6rrfa4wq6in6zgxl@linutronix.de>
On Mon, 24 Jun 2019, Sebastian Andrzej Siewior wrote:
> On 2019-06-19 17:48:09 [+0200], John Kacur wrote:
> >
> > If anyone objects because they are actively using systems that don't have
> > gettid() in the library, please speak-up, for now this is in
> > unstable/devel/latest-devel
>
> ehm. gettid() is defined in
> src/lib/rt-utils.c
>
> so how should someone not have that one on his system?
The sentence does say, systems that don't have gettid() in the LIBRARY.
That being said, Kurt, would like to come up with a smarter patch that
uses the glibc version if detected else falls back on this one?
Then you need to clean it up everywhere, not just for the deadline tests.
Consider this patch NAKed for now. (it's only in the latest-devel not the
latest version anyway)
>
> glibc 2.30 will have gettid() [0] so maybe you could avoid using that
> one from rt-utils.c once you detect it in glibc.
>
> [0] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=1d0fc213824eaa2a8f8c4385daaa698ee8fb7c92;hp=f289e656ec8221756519a601042bc9fbe1b310fb
>
> > Signed-off-by: John Kacur <jkacur@redhat.com>
>
> Sebastian
>
next prev parent reply other threads:[~2019-06-25 9:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 10:38 [PATCH 0/6] rt-tests: deadline: Cleanups Kurt Kanzenbach
2019-06-18 10:38 ` [PATCH 1/6] rt-tests: deadline: Remove duplicated code for sched_{set,get}_attr Kurt Kanzenbach
2019-06-19 15:46 ` John Kacur
2019-06-18 10:38 ` [PATCH 2/6] rt-tests: cyclicdeadline: Remove unused getcpu code Kurt Kanzenbach
2019-06-19 15:46 ` John Kacur
2019-06-18 10:38 ` [PATCH 3/6] rt-tests: deadline: Remove duplicated gettid() code Kurt Kanzenbach
2019-06-19 15:48 ` John Kacur
2019-06-24 13:40 ` Sebastian Andrzej Siewior
2019-06-25 9:29 ` John Kacur [this message]
2019-06-25 13:52 ` Sebastian Andrzej Siewior
2019-06-18 10:38 ` [PATCH 4/6] rt-tests: cyclicdeadline: Add options to usage Kurt Kanzenbach
2019-06-19 15:48 ` John Kacur
2019-06-18 10:38 ` [PATCH 5/6] rt-tests: cyclicdeadline: Print fail only if something failed Kurt Kanzenbach
2019-06-19 15:49 ` John Kacur
2019-06-18 10:38 ` [PATCH 6/6] rt-tests: cyclicdeadline: Fix cgroup setup Kurt Kanzenbach
2019-06-19 15:49 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1906251117160.4274@planxty.home \
--to=jkacur@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=kurt@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox