From: John Kacur <jkacur@redhat.com>
To: Clark Williams <williams@redhat.com>
Cc: linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] pi_stress: limit the number of inversion groups to the number of online cores
Date: Tue, 21 Jul 2020 18:29:32 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.23.451.2007211829040.195349@fionn> (raw)
In-Reply-To: <20200721211022.734344-1-williams@redhat.com>
On Tue, 21 Jul 2020, Clark Williams wrote:
> Each inversion group is three SCHED_FIFO threads, so the chances of more groups
> than online cores actually getting to run is very slim. Limit the number of
> groups requested to be <= the number of online cpus.
>
> Signed-off-by: Clark Williams <williams@redhat.com>
> ---
> src/pi_tests/pi_stress.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
> index 0ed844c636cd..ce446d4ea037 100644
> --- a/src/pi_tests/pi_stress.c
> +++ b/src/pi_tests/pi_stress.c
> @@ -1327,6 +1327,12 @@ void process_command_line(int argc, char **argv)
> break;
> case 'g':
> ngroups = strtol(optarg, NULL, 10);
> + if (ngroups > num_processors) {
> + pi_error("the number of groups cannot exceed "
> + "the number of online processors (%d)\n",
> + num_processors);
> + exit(-1);
> + }
> pi_info("number of groups set to %d\n", ngroups);
> break;
> case 'r':
> --
> 2.26.2
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
prev parent reply other threads:[~2020-07-21 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 21:10 [PATCH] pi_stress: limit the number of inversion groups to the number of online cores Clark Williams
2020-07-21 22:29 ` John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.23.451.2007211829040.195349@fionn \
--to=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox