From: John Kacur <jkacur@redhat.com>
To: Crystal Wood <crwood@redhat.com>
Cc: ende.tan@starfivetech.com, linux-rt-users@vger.kernel.org,
mtosatti@redhat.com, williams@redhat.com,
leyfoon.tan@starfivetech.com, endeneer@gmail.com
Subject: Re: [1/1] rt-tests: cyclictest: Suppress unused parameter warnings
Date: Fri, 20 Dec 2024 13:02:00 -0500 (EST) [thread overview]
Message-ID: <ca9f9d61-a81d-9343-7872-f1110ef7b247@redhat.com> (raw)
In-Reply-To: <afa631a73622f8b0d49dbe4608764b353841f472.camel@redhat.com>
On Fri, 13 Dec 2024, Crystal Wood wrote:
> On Fri, 2024-12-13 at 00:24 +0800, ende.tan@starfivetech.com wrote:
> > From: Tan En De <ende.tan@starfivetech.com>
> >
> > Mark unused parameters with `__attribute__((unused))`.
> >
> > Signed-off-by: Tan En De <ende.tan@starfivetech.com>
> > ---
> > src/cyclictest/cyclictest.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Can we just turn off this warning? Unused parameters are entirely
> normal in functions used as callbacks as well as with ifdefs, and it
> seems like a low value warning to begin with (there's a reason it's not
> in -Wall).
I believe it IS in -Wall
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
John
next prev parent reply other threads:[~2024-12-20 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 16:24 [1/1] rt-tests: cyclictest: Suppress unused parameter warnings ende.tan
2024-12-13 6:35 ` Crystal Wood
2024-12-20 18:02 ` John Kacur [this message]
2024-12-21 1:06 ` Crystal Wood
2024-12-20 18:07 ` John Kacur
2024-12-21 0:00 ` EnDe Tan
2025-01-07 22:06 ` Crystal Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca9f9d61-a81d-9343-7872-f1110ef7b247@redhat.com \
--to=jkacur@redhat.com \
--cc=crwood@redhat.com \
--cc=ende.tan@starfivetech.com \
--cc=endeneer@gmail.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).