From: Yunfeng Ye <yeyunfeng@huawei.com>
To: John Kacur <jkacur@redhat.com>
Cc: <williams@redhat.com>, <linux-rt-users@vger.kernel.org>,
Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>
Subject: Re: [PATCH] rt-tests: cyclictest: add '\n' symbol for printf in rstat_shm_open()
Date: Thu, 2 Jul 2020 09:25:52 +0800 [thread overview]
Message-ID: <e56fa215-ec8c-ecef-e4e4-019446eba516@huawei.com> (raw)
In-Reply-To: <alpine.LFD.2.21.2007011137180.7008@planxty>
On 2020/7/1 23:38, John Kacur wrote:
>
>
> On Sat, 20 Jun 2020, Yunfeng Ye wrote:
>
>> The infomation "pid = xxx" is printed with other infomation on the same
>> line. so add '\n' symbol for printf in rstat_shm_open().
>>
>> Signed-off-by: yeyunfeng <yeyunfeng@huawei.com>
>> ---
>> src/cyclictest/cyclictest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>> index b3d72caa10ce..d1c148563dad 100644
>> --- a/src/cyclictest/cyclictest.c
>> +++ b/src/cyclictest/cyclictest.c
>> @@ -1910,7 +1910,7 @@ static int rstat_shm_open(void)
>> pid_t pid;
>>
>> pid = getpid();
>> - printf("pid = %d", pid);
>> + printf("pid = %d\n", pid);
>>
>> snprintf(shm_name, SHM_BUF_SIZE, "%s%d", "/cyclictest", pid);
>>
>> --
>> 1.8.3.1
>>
>>
> oops, that looks like my debug code that I forgot to remove. Do you want
> to send a patch removing that line?
>
ok, I will send a patch v2, thanks.
> Thanks
>
> John Kacur
>
>
prev parent reply other threads:[~2020-07-02 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 2:44 [PATCH] rt-tests: cyclictest: add '\n' symbol for printf in rstat_shm_open() Yunfeng Ye
2020-07-01 15:38 ` John Kacur
2020-07-02 1:25 ` Yunfeng Ye [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e56fa215-ec8c-ecef-e4e4-019446eba516@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).