From: John Kacur <jkacur@redhat.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: RT <linux-rt-users@vger.kernel.org>,
Clark Williams <williams@redhat.com>,
Pradipta Kumar Sahoo <psahoo@redhat.com>,
"Reported-by : Peter Xu" <peterx@redhat.com>
Subject: Re: [PATCH] rt-tests: oslat: print version string
Date: Thu, 11 Feb 2021 08:42:41 -0500 (EST) [thread overview]
Message-ID: <ec91e6ef-11f7-5cb7-445-dd5bf2d467@redhat.com> (raw)
In-Reply-To: <20210211074529.wxm66aeszzfs5gek@beryllium.lan>
On Thu, 11 Feb 2021, Daniel Wagner wrote:
> > --- a/src/oslat/oslat.c
> > +++ b/src/oslat/oslat.c
> > @@ -512,7 +512,6 @@ static void handle_alarm(int code)
> >
> > static void usage(int error)
> > {
> > - printf("oslat V %1.2f\n", VERSION);
> > printf("Usage:\n"
>
> Why do you remove the version string in the usage output. Every other
> tool prints it?
>
>
Because the version is printed out before the call to parse the options.
If you don't remove it here, it gets printed out twice.
John
next prev parent reply other threads:[~2021-02-11 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 4:42 [PATCH] rt-tests: oslat: print version string John Kacur
2021-02-11 7:45 ` Daniel Wagner
2021-02-11 13:42 ` John Kacur [this message]
2021-02-11 13:48 ` Daniel Wagner
2021-02-11 14:05 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec91e6ef-11f7-5cb7-445-dd5bf2d467@redhat.com \
--to=jkacur@redhat.com \
--cc=dwagner@suse.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=psahoo@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox