Re: [PATCH v2 2/3] rt-tests: cyclictest: Support idle state disabling via libcpupower

[John Kacur <jkacur@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]



On Fri, 6 Dec 2024, Sebastian Andrzej Siewior wrote:

> On 2024-11-27 10:45:49 [+0100], Tomas Glozar wrote:
> > st 27. 11. 2024 v 1:09 odesílatel Crystal Wood <crwood@redhat.com> napsal:
> > >
> > > This could be said about the laptop and power_management checks too...
> > > I'd go with verbose info prints rather than warnings for all three, if
> > > anything.
> > >
> > 
> > I agree. I believe my code is consistent with what we already have.
> > When you do cyclictest --default-system, you also get a warning about
> > not setting cpu_dma_latency, despite it being what you have explicitly
> > requested. My patch just does the same thing for --deepest-idle-state.
> 
> What is the default behaviour and what is the intended behaviour?
> Couldn't we somehow avoid adding yet another option?

The default doesn't change, you don't have to use the new option.
We want to be able to measure whether using some level of power saving 
will still give us acceptible soft realtime behaviour.

John

> 
> > I suggest deferring this to a future patch that would remove the
> > warnings and another one to refactor the code.
> 
> Sebastian
> 
>