From: Tom Zanussi <zanussi@kernel.org>
To: linux-rt-users@vger.kernel.org
Cc: rostedt@goodmis.org, tglx@linutronix.de, C.Emde@osadl.org,
jkacur@redhat.com, bigeasy@linutronix.de,
daniel.wagner@siemens.com, julia@ni.com
Subject: [PATCH 13/15] s390/mm: Fix missed tsk->pagefault_disabled conversion to pagefault_disable()
Date: Tue, 14 Aug 2018 13:54:06 -0500 [thread overview]
Message-ID: <f97ca04fb6bb69f9af55231470cd4f3ce4cf921e.1534263273.git.tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <cover.1534263273.git.tom.zanussi@linux.intel.com>
In-Reply-To: <cover.1534263273.git.tom.zanussi@linux.intel.com>
v3.18.117-rt105 rt-stable review patch. If anyone has any objections,
please let me know.
------------------
From: Tom Zanussi <tom.zanussi@linux.intel.com>
stable-rt commit 7be67fb433a0 ("mm: pagefault_disabled()") does this for s390:
- if (unlikely(!user_space_fault(regs) || in_atomic() || !mm ||
+ if (unlikely(!user_space_fault(regs) || !mm ||
tsk->pagefault_disabled))
whereas elsewhere it does the right thing for other arches e.g.:
- if (in_atomic() || !mm || current->pagefault_disabled)
+ if (!mm || pagefault_disabled())
i.e. because of the linebreak it misses the tsk->pagefault_disabled
and leaves it unconverted.
So fix that up and use pagefault_disabled() as intended.
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
arch/s390/mm/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c
index 43ec237a17e2..466154e1dfc0 100644
--- a/arch/s390/mm/fault.c
+++ b/arch/s390/mm/fault.c
@@ -436,7 +436,7 @@ static inline int do_exception(struct pt_regs *regs, int access)
*/
fault = VM_FAULT_BADCONTEXT;
if (unlikely(!user_space_fault(regs) || !mm ||
- tsk->pagefault_disabled))
+ pagefault_disabled()))
goto out;
address = trans_exc_code & __FAIL_ADDR_MASK;
--
2.14.1
next prev parent reply other threads:[~2018-08-14 21:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 18:53 [PATCH 00/15] [ANNOUNCE] 3.18.117-rt105-rc2 Tom Zanussi
2018-08-14 18:53 ` [PATCH 01/15] sched: Remove TASK_ALL Tom Zanussi
2018-08-14 18:53 ` [PATCH 02/15] arm*: disable NEON in kernel mode Tom Zanussi
2018-08-14 18:53 ` [PATCH 03/15] posix-timers: move the rcu head out of the union Tom Zanussi
2018-08-14 18:53 ` [PATCH 04/15] tracing: Fix rcu splat from idle CPU on boot Tom Zanussi
2018-08-14 18:53 ` [PATCH 05/15] alarmtimer: Prevent live lock in alarm_cancel() Tom Zanussi
2018-08-14 18:53 ` [PATCH 06/15] locking: add types.h Tom Zanussi
2018-08-14 18:54 ` [PATCH 07/15] net: use task_struct instead of CPU number as the queue owner on -RT Tom Zanussi
2018-08-14 18:54 ` [PATCH 08/15] seqlock: provide the same ordering semantics as mainline Tom Zanussi
2018-08-14 18:54 ` [PATCH 09/15] squashfs: make use of local lock in multi_cpu decompressor Tom Zanussi
2018-08-14 20:36 ` Julia Cartwright
2018-08-14 20:58 ` Tom Zanussi
2018-08-14 18:54 ` [PATCH 10/15] Revert "fs, jbd: pull your plug when waiting for space" Tom Zanussi
2018-08-14 18:54 ` [PATCH 11/15] powerpc/vdso64: Use double word compare on pointers Tom Zanussi
2018-08-14 18:54 ` [PATCH 12/15] powerpc: ps3/device-init.c - adapt to completions using swait vs wait Tom Zanussi
2018-08-14 18:54 ` Tom Zanussi [this message]
2018-08-14 18:54 ` [PATCH 14/15] um: Use POSIX ucontext_t instead of struct ucontext Tom Zanussi
2018-08-14 18:54 ` [PATCH 15/15] Linux 3.18.117-rt105-rc2 Tom Zanussi
-- strict thread matches above, loose matches on Subject: below --
2018-08-02 22:25 [PATCH 00/15][ANNOUNCE] 3.18.117-rt105-rc1 Tom Zanussi
2018-08-03 13:25 ` [PATCH 13/15] s390/mm: Fix missed tsk->pagefault_disabled conversion to pagefault_disable() Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97ca04fb6bb69f9af55231470cd4f3ce4cf921e.1534263273.git.tom.zanussi@linux.intel.com \
--to=zanussi@kernel.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=daniel.wagner@siemens.com \
--cc=jkacur@redhat.com \
--cc=julia@ni.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).