From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Ming Yu <a0282524688@gmail.com>,
tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org,
brgl@bgdev.pl, andi.shyti@kernel.org, mkl@pengutronix.de,
mailhol.vincent@wanadoo.fr, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, wim@linux-watchdog.org, linux@roeck-us.net,
jdelvare@suse.com, alexandre.belloni@bootlin.com
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v7 3/7] i2c: Add Nuvoton NCT6694 I2C support
Date: Fri, 7 Feb 2025 20:06:27 +0100 [thread overview]
Message-ID: <01801937-6257-4381-bf18-90badf795da8@wanadoo.fr> (raw)
In-Reply-To: <20250207074502.1055111-4-a0282524688@gmail.com>
Le 07/02/2025 à 08:44, Ming Yu a écrit :
> This driver supports I2C adapter functionality for NCT6694 MFD
> device based on USB interface, each I2C controller use default
> baudrate(100K).
...
> +static int nct6694_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
> +{
> + struct nct6694_i2c_data *data = adap->algo_data;
> + struct nct6694_i2c_deliver *deliver = &data->deliver;
> + static const struct nct6694_cmd_header cmd_hd = {
> + .mod = NCT6694_I2C_MOD,
> + .cmd = NCT6694_I2C_DELIVER,
> + .sel = NCT6694_I2C_DELIVER_SEL,
> + .len = cpu_to_le16(sizeof(*deliver))
> + };
> + int ret, i;
> +
> + for (i = 0; i < num ; i++) {
Tiny tiny nitpick: unneeded extra space after num
> + struct i2c_msg *msg_temp = &msgs[i];
...
CJ
next prev parent reply other threads:[~2025-02-07 19:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 7:44 [PATCH v7 0/7] Add Nuvoton NCT6694 MFD drivers Ming Yu
2025-02-07 7:44 ` [PATCH v7 1/7] mfd: Add core driver for Nuvoton NCT6694 Ming Yu
2025-02-07 18:36 ` Christophe JAILLET
2025-02-12 2:20 ` Ming Yu
2025-02-07 7:44 ` [PATCH v7 2/7] gpio: Add Nuvoton NCT6694 GPIO support Ming Yu
2025-02-07 7:44 ` [PATCH v7 3/7] i2c: Add Nuvoton NCT6694 I2C support Ming Yu
2025-02-07 19:06 ` Christophe JAILLET [this message]
2025-02-12 2:25 ` Ming Yu
2025-02-07 7:44 ` [PATCH v7 4/7] can: Add Nuvoton NCT6694 CANFD support Ming Yu
2025-02-07 12:15 ` Marc Kleine-Budde
2025-02-07 15:00 ` Vincent Mailhol
2025-02-07 15:51 ` Marc Kleine-Budde
2025-02-12 2:58 ` Ming Yu
2025-02-12 2:49 ` Ming Yu
2025-02-28 10:34 ` Marc Kleine-Budde
2025-02-21 8:01 ` Ming Yu
2025-02-21 8:08 ` Marc Kleine-Budde
2025-02-21 8:52 ` Ming Yu
2025-02-07 19:17 ` Christophe JAILLET
2025-02-12 2:59 ` Ming Yu
2025-02-07 7:45 ` [PATCH v7 5/7] watchdog: Add Nuvoton NCT6694 WDT support Ming Yu
2025-02-07 20:30 ` Christophe JAILLET
2025-02-12 2:27 ` Ming Yu
2025-02-07 7:45 ` [PATCH v7 6/7] hwmon: Add Nuvoton NCT6694 HWMON support Ming Yu
2025-02-07 7:45 ` [PATCH v7 7/7] rtc: Add Nuvoton NCT6694 RTC support Ming Yu
2025-04-08 12:54 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01801937-6257-4381-bf18-90badf795da8@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=a0282524688@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdelvare@suse.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tmyu0@nuvoton.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox