From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8361E13CA88 for ; Thu, 11 Apr 2024 06:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712816281; cv=none; b=FxXg642xgnv0vt2MWjKOgqgjQd126am5tFA6ULVKgrvCaELaXnV6HcLvnIKiB+zAHsFX5WTV9vUCJFoFocRaDjBRvKhnVt573TzBNKOeRyM5ru2hPrcvBrZSK6s8mxIfoETgvTn+CZnpmzQ2HBB4OSZ6JhJOfa1sY/qb924u+VM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712816281; c=relaxed/simple; bh=i9P3bAcnwVB5TPl/lPoV1TrVudMdEcrlGwHTwNAN+Ms=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ozgNWhBTh86gva3DwpE0eqxYlUP9dYAE73Nj/xdn63taD5S3Jrtcon74veBCEjXjfVjtldkkvc7ZDPF5YCwrvu6KC3GzZx6MF0RB8tvIKU9DorNgWcx/Ad5Dd+6ux92RKA5ey5neEWpglCDRsfuZXkbFAnUBLtgKFeY8MW+NTtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pdclmzqo; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pdclmzqo" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3462178fbf9so1312358f8f.1 for ; Wed, 10 Apr 2024 23:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712816278; x=1713421078; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dIqGBLkwho0VDUiHAkhF1AiHua3U+TbpGgqUfassRGY=; b=pdclmzqoKgm+9vNElevyUUDKHT/OD6ai/Wxmgaepuwc/sDD63s6sVpkQSfCVK9e3X+ jkAp/n+Iiy8jxzIIwzWvgdpGY/VDhGD4zoCDgDVrEV7NbscvbOH1pyxAghtzYjP33IHv hpkljpvp4Zyh43WkrtTqhAtm/rbzGPgHY6/ecHbh8krBCi2Qz1Y/Q/yM46rRYgEC4VkX drXi5XwhjLMr06q4WfUlsfsUR2zzfBEG5ox+jdoHcUY+R7WNU3XFsi15QLnkVOjsrrZV 2WSqLS2nR4pGTwaC7R3k1/mlL9qj4IVigDa2ZOtZXpO43dtJIl9aGb+faiqUGAQ1DBsR zFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712816278; x=1713421078; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dIqGBLkwho0VDUiHAkhF1AiHua3U+TbpGgqUfassRGY=; b=UtFNzPczck4D9E2qoM7SwwbaDyBYnB+KwLomnfMAlwSevXBrJf+O3SJ5+NhM6jA8ra mdzx076GJyB1sxv7wSBQl4yVRK1L0/gJ5PMscYQ3D1NGiOfk8tursaCL3Ri4hVV6I6J3 Aa6l+rov5bFVfaFWwCjb4ymiSwLLHK8I1tn/C6aw1b9vfFw4Dh5S96GBNd8DK+61uGyV jUlCB+xQkzNEoEUBpGJ9hQUNceTYNzEX/xRw9JM49x2E0SdlYDbT5LliEm3rsw8YPFpQ wIc3ceEypv+S4rW8IAWlUCuCXZ9b9u9rY75/HHqT4wRME6XAEiUTuoxXzc63xRRpHCxw VGcQ== X-Forwarded-Encrypted: i=1; AJvYcCW2V88eMnIu6Ne8HlneAcvPZ631TmH1VFBNGtqirzop7ir0K/Xd4IA69G2xwX9501hrfPoFN6lc7fiABZHaah6YO5yjhaVilJWn X-Gm-Message-State: AOJu0YwCaRe4O/VKBY6UDkeAH+SClMT06G4zbydk4KmIHekjiTXVOky2 OR2F1AoMvCB4uqONHjxMdjkn6DBurIFFbRii17YTo2HcnILWpX36pjlR/pfS/tU= X-Google-Smtp-Source: AGHT+IEJxgJl8yVXSeIGYg35EweCjbaFB2dDJFg8DQCcoBybET4ev5s9QxHjmm6Hc4tA0Ocqh3UGjw== X-Received: by 2002:adf:fc46:0:b0:33e:cf4d:c583 with SMTP id e6-20020adffc46000000b0033ecf4dc583mr3434952wrs.16.1712816277879; Wed, 10 Apr 2024 23:17:57 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id s19-20020adfe013000000b00346bb778e8bsm769518wrh.5.2024.04.10.23.17.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 23:17:57 -0700 (PDT) Message-ID: <130d47d8-3294-44be-9a8c-8474d342cb12@linaro.org> Date: Thu, 11 Apr 2024 08:17:55 +0200 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: rtc: lpc32xx-rtc: convert to dtschema To: Alexandre Belloni , Javier Carrasco Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiaxun Yang , Vladimir Zapolskiy , Joel Stanley , Andrew Jeffery , Maxime Coquelin , Alexandre Torgue , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com References: <20240410-rtc_dtschema-v2-0-d32a11ab0745@gmail.com> <20240410-rtc_dtschema-v2-2-d32a11ab0745@gmail.com> <202404102043571b7450b5@mail.local> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <202404102043571b7450b5@mail.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/04/2024 22:43, Alexandre Belloni wrote: > On 10/04/2024 17:55:34+0200, Javier Carrasco wrote: >> Convert existing binding to dtschema to support validation. >> >> Add the undocumented 'clocks' property. >> >> Signed-off-by: Javier Carrasco >> --- >> .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- >> .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ >> 2 files changed, 41 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt b/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> deleted file mode 100644 >> index a87a1e9bc060..000000000000 >> --- a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -* NXP LPC32xx SoC Real Time Clock controller >> - >> -Required properties: >> -- compatible: must be "nxp,lpc3220-rtc" >> -- reg: physical base address of the controller and length of memory mapped >> - region. >> -- interrupts: The RTC interrupt >> - >> -Example: >> - >> - rtc@40024000 { >> - compatible = "nxp,lpc3220-rtc"; >> - reg = <0x40024000 0x1000>; >> - interrupts = <52 0>; >> - }; >> diff --git a/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> new file mode 100644 >> index 000000000000..62ddeef961e9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> @@ -0,0 +1,41 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/nxp,lpc32xx-rtc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP LPC32xx SoC Real Time Clock >> + >> +maintainers: >> + - Javier Carrasco >> + >> +allOf: >> + - $ref: rtc.yaml# >> + >> +properties: >> + compatible: >> + const: nxp,lpc3220-rtc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 > > As I explained the clock doesn't really exist, there is no control over > it, it is a fixed 32768 Hz crystal, there is no point in describing it > as this is already the input clock of the SoC. That's common for many SoCs but it is still (at least for them) input to the RTC. On some SoC boards 32 kHz is controllable. But if you think it is not correct here, then we should drop it from DTS. Best regards, Krzysztof