From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by gmr-mx.google.com with ESMTPS id r2si2894338pfr.0.2016.02.06.06.49.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Feb 2016 06:49:17 -0800 (PST) From: Laxman Dewangan To: , , , , , , CC: , , , Laxman Dewangan Subject: [rtc-linux] [PATCH V4 3/6] rtc: max77686: use rtc regmap to access RTC registers Date: Sat, 6 Feb 2016 20:07:24 +0530 Message-ID: <1454769447-785-4-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> References: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , rtc_regmap should be used to access all RTC registers instead of parent regmap regardless of what chip or property have it. This makes the register access uniform and extendible for other chips. Signed-off-by: Laxman Dewangan CC: Krzysztof Kozlowski CC: Javier Martinez Canillas Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas --- Changes from V1: None, added reviewed/tested by. Changes from V1: None Changes from V1: None, become 3rd on series. drivers/rtc/rtc-max77686.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 253cf12..11f74ed 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -370,7 +370,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) goto out; } - ret = regmap_read(info->max77686->regmap, + ret = regmap_read(info->max77686->rtc_regmap, map[REG_RTC_AE1], &val); if (ret < 0) { dev_err(info->dev, @@ -426,7 +426,8 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) goto out; } - ret = regmap_write(info->max77686->regmap, map[REG_RTC_AE1], 0); + ret = regmap_write(info->max77686->rtc_regmap, + map[REG_RTC_AE1], 0); } else { ret = regmap_bulk_read(info->max77686->rtc_regmap, map[REG_ALARM1_SEC], data, @@ -471,7 +472,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) goto out; if (info->drv_data->alarm_enable_reg) { - ret = regmap_write(info->max77686->regmap, map[REG_RTC_AE1], + ret = regmap_write(info->max77686->rtc_regmap, map[REG_RTC_AE1], MAX77802_ALARM_ENABLE_VALUE); } else { ret = regmap_bulk_read(info->max77686->rtc_regmap, -- 2.1.4 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.