From: Chen Zhong <chen.zhong@mediatek.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Linus Walleij <linus.walleij@linaro.org>,
Beomho Seo <beomho.seo@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Jaechul Lee <jcsing.lee@samsung.com>,
Chen Zhong <chen.zhong@mediatek.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
<linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <linux-rtc@vger.kernel.org>
Subject: [PATCH v6 1/6] mfd: mt6397: create irq mappings in mfd core driver
Date: Wed, 25 Oct 2017 21:15:59 +0800 [thread overview]
Message-ID: <1508937364-30054-2-git-send-email-chen.zhong@mediatek.com> (raw)
In-Reply-To: <1508937364-30054-1-git-send-email-chen.zhong@mediatek.com>
The core driver should create and manage irq mappings instead of
leaf drivers. This patch change to pass irq domain to
devm_mfd_add_devices() and it will create mapping for irq resources
automatically. And remove irq mapping in rtc driver since this has
been done in core driver.
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
---
drivers/mfd/mt6397-core.c | 4 ++--
drivers/rtc/rtc-mt6397.c | 7 +++----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index 04a601f..6546d7f 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -289,7 +289,7 @@ static int mt6397_probe(struct platform_device *pdev)
ret = devm_mfd_add_devices(&pdev->dev, -1, mt6323_devs,
ARRAY_SIZE(mt6323_devs), NULL,
- 0, NULL);
+ 0, pmic->irq_domain);
break;
case MT6397_CID_CODE:
@@ -304,7 +304,7 @@ static int mt6397_probe(struct platform_device *pdev)
ret = devm_mfd_add_devices(&pdev->dev, -1, mt6397_devs,
ARRAY_SIZE(mt6397_devs), NULL,
- 0, NULL);
+ 0, pmic->irq_domain);
break;
default:
diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index 1a61fa5..385f830 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -322,10 +322,9 @@ static int mtk_rtc_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
rtc->addr_base = res->start;
- res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
- if (rtc->irq <= 0)
- return -EINVAL;
+ rtc->irq = platform_get_irq(pdev, 0);
+ if (rtc->irq < 0)
+ return rtc->irq;
rtc->regmap = mt6397_chip->regmap;
rtc->dev = &pdev->dev;
--
1.7.9.5
next prev parent reply other threads:[~2017-10-25 14:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 13:15 [PATCH v6 0/6] Add MediaTek PMIC keys support Chen Zhong
2017-10-25 13:15 ` Chen Zhong [this message]
2017-10-25 13:16 ` [PATCH v6 2/6] dt-bindings: input: Add common keyboard document bindings Chen Zhong
2018-03-29 16:15 ` Dmitry Torokhov
2017-10-25 13:16 ` [PATCH v6 3/6] dt-bindings: input: Add document bindings for mtk-pmic-keys Chen Zhong
2018-03-29 16:16 ` Dmitry Torokhov
2017-10-25 13:16 ` [PATCH v6 4/6] dt-bindings: mfd: Add bindings for the keys as subnode of PMIC Chen Zhong
2017-10-25 13:16 ` [PATCH v6 5/6] input: Add MediaTek PMIC keys support Chen Zhong
2017-10-25 13:16 ` [PATCH v6 6/6] mfd: mt6397: Add PMIC keys support to MT6397 driver Chen Zhong
[not found] ` <808b2029da224ab687fb0553cbc1c68e@mtkmbs08n1.mediatek.inc>
2018-03-22 2:17 ` [PATCH v6 0/6] Add MediaTek PMIC keys support Sean Wang
2018-03-23 18:54 ` Dmitry Torokhov
2018-03-27 8:05 ` Lee Jones
2018-03-27 10:47 ` Matthias Brugger
2018-03-28 10:26 ` Lee Jones
2018-03-29 2:31 ` Chen Zhong
2018-03-29 13:04 ` Lee Jones
2018-03-29 16:15 ` Dmitry Torokhov
2018-04-10 5:46 ` Chen Zhong
2018-04-16 14:18 ` [GIT PULL] Immutable branch between MFD, Input and RTC due for the v4.18 merge window Lee Jones
2018-04-26 6:53 ` Chen Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508937364-30054-2-git-send-email-chen.zhong@mediatek.com \
--to=chen.zhong@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=beomho.seo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eddie.huang@mediatek.com \
--cc=javier@osg.samsung.com \
--cc=jcsing.lee@samsung.com \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).