From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outils.crapouillou.net ([89.234.176.41]:46682 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbeGNNow (ORCPT ); Sat, 14 Jul 2018 09:44:52 -0400 Date: Sat, 14 Jul 2018 15:25:33 +0200 From: Paul Cercueil Subject: Re: [PATCH] rtc: jz4740: Add support for the JZ4725B, JZ4760, JZ4770 To: Alexandre Belloni Cc: Alessandro Zummo , Rob Herring , Mark Rutland , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <1531574734.2831.0@smtp.crapouillou.net> In-Reply-To: <20180714131920.GU16084@piout.net> References: <20180713151424.13000-1-paul@crapouillou.net> <20180714131920.GU16084@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-rtc-owner@vger.kernel.org List-ID: Hi Alexandre, Le sam. 14 juil. 2018 =E0 15:19, Alexandre Belloni=20 a =E9crit : > Hello, >=20 > On 13/07/2018 17:14:24+0200, Paul Cercueil wrote: >> The RTC in the JZ4725B works just like the one in the JZ4740. >>=20 >> The RTC in the JZ4760 and JZ4770 work just like the one in the=20 >> JZ4780. >>=20 >> Signed-off-by: Paul Cercueil >> --- >> Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt | 3=20 >> +++ >> drivers/rtc/rtc-jz4740.c | 11=20 >> ++++++++++- >> 2 files changed, 13 insertions(+), 1 deletion(-) >>=20 >> diff --git=20 >> a/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt=20 >> b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt >> index 41c7ae18fd7b..a9e821de84f2 100644 >> --- a/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt >> +++ b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt >> @@ -4,6 +4,9 @@ Required properties: >>=20 >> - compatible: One of: >> - "ingenic,jz4740-rtc" - for use with the JZ4740 SoC >> + - "ingenic,jz4725b-rtc" - for use with the JZ4725B SoC >> + - "ingenic,jz4760-rtc" - for use with the JZ4760 SoC >> + - "ingenic,jz4770-rtc" - for use with the JZ4770 SoC >> - "ingenic,jz4780-rtc" - for use with the JZ4780 SoC >> - reg: Address range of rtc register set >> - interrupts: IRQ number for the alarm interrupt >> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c >> index d0a891777f44..1c867e3a0ea5 100644 >> --- a/drivers/rtc/rtc-jz4740.c >> +++ b/drivers/rtc/rtc-jz4740.c >> @@ -54,6 +54,9 @@ >>=20 >> enum jz4740_rtc_type { >> ID_JZ4740, >> + ID_JZ4725B, >> + ID_JZ4760, >> + ID_JZ4770, >=20 > I wouldn't introduce those ids unless there are handling differences=20 > at > some point. Well there are handling differences, see below. >> ID_JZ4780, >> }; >>=20 >> @@ -114,7 +117,7 @@ static inline int jz4740_rtc_reg_write(struct=20 >> jz4740_rtc *rtc, size_t reg, >> { >> int ret =3D 0; >>=20 >> - if (rtc->type >=3D ID_JZ4780) >> + if (rtc->type >=3D ID_JZ4760) >=20 > This would avoid that change (and the test would preferably be=20 > (rtc->type =3D=3D ID_JZ4780)) That branch should be taken if the SoC is JZ4760, JZ4770 or JZ4780. It should not be taken if the SoC is JZ4740 or JZ4725B. >> ret =3D jz4780_rtc_enable_write(rtc); >> if (ret =3D=3D 0) >> ret =3D jz4740_rtc_wait_write_ready(rtc); >> @@ -300,6 +303,9 @@ static void jz4740_rtc_power_off(void) >>=20 >> static const struct of_device_id jz4740_rtc_of_match[] =3D { >> { .compatible =3D "ingenic,jz4740-rtc", .data =3D (void *)ID_JZ4740 }= , >> + { .compatible =3D "ingenic,jz4725b-rtc", .data =3D (void *)ID_JZ4725B= =20 >> }, >> + { .compatible =3D "ingenic,jz4760-rtc", .data =3D (void *)ID_JZ4760 }= , >> + { .compatible =3D "ingenic,jz4770-rtc", .data =3D (void *)ID_JZ4770 }= , >> { .compatible =3D "ingenic,jz4780-rtc", .data =3D (void *)ID_JZ4780 }= , >> {}, >> }; >> @@ -428,6 +434,9 @@ static const struct dev_pm_ops jz4740_pm_ops =3D { >>=20 >> static const struct platform_device_id jz4740_rtc_ids[] =3D { >> { "jz4740-rtc", ID_JZ4740 }, >> + { "jz4725b-rtc", ID_JZ4725B }, >> + { "jz4760-rtc", ID_JZ4760 }, >> + { "jz4770-rtc", ID_JZ4770 }, >> { "jz4780-rtc", ID_JZ4780 }, >> {} >> }; >> -- >> 2.11.0 >>=20 >=20 > -- > Alexandre Belloni, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com =