From: zhong jiang <zhongjiang@huawei.com>
To: <a.zummo@towertech.it>, <alexandre.belloni@bootlin.com>,
<baruch@tkos.co.il>, <linux-rtc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code
Date: Mon, 13 Aug 2018 19:31:25 +0800 [thread overview]
Message-ID: <1534159885-25364-3-git-send-email-zhongjiang@huawei.com> (raw)
In-Reply-To: <1534159885-25364-1-git-send-email-zhongjiang@huawei.com>
PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
just replace them rather than duplicating its implement.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/rtc/rtc-ds1347.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c
index 938512c..b97b67f 100644
--- a/drivers/rtc/rtc-ds1347.c
+++ b/drivers/rtc/rtc-ds1347.c
@@ -155,10 +155,7 @@ static int ds1347_probe(struct spi_device *spi)
rtc = devm_rtc_device_register(&spi->dev, "ds1347",
&ds1347_rtc_ops, THIS_MODULE);
- if (IS_ERR(rtc))
- return PTR_ERR(rtc);
-
- return 0;
+ return PTR_ERR_OR_ZERO(rtc);
}
static struct spi_driver ds1347_driver = {
--
1.7.12.4
next prev parent reply other threads:[~2018-08-13 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 11:31 [PATCH 0/2] rtc: Use PTR_ERR_OR_ZERO to replace the open code zhong jiang
2018-08-13 11:31 ` [PATCH 1/2] rtc:rtc-digicolor: " zhong jiang
2018-08-14 4:18 ` Baruch Siach
2018-08-14 16:15 ` Alexandre Belloni
2018-08-15 7:16 ` zhong jiang
2018-08-15 8:20 ` Alexandre Belloni
2018-08-13 11:31 ` zhong jiang [this message]
2018-08-14 4:18 ` [PATCH 2/2] rtc:rtc-ds1347: " Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534159885-25364-3-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).