From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC06C43381 for ; Mon, 11 Mar 2019 06:05:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67EC820657 for ; Mon, 11 Mar 2019 06:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726527AbfCKGFN (ORCPT ); Mon, 11 Mar 2019 02:05:13 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:22839 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725932AbfCKGFN (ORCPT ); Mon, 11 Mar 2019 02:05:13 -0400 X-UUID: 13bac23f7a824a24b928c997eeef8e86-20190311 X-UUID: 13bac23f7a824a24b928c997eeef8e86-20190311 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 648818602; Mon, 11 Mar 2019 14:05:04 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Mar 2019 14:05:02 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 11 Mar 2019 14:05:01 +0800 Message-ID: <1552284302.19917.2.camel@mtksdaap41> Subject: Re: [PATCH v2 8/9] rtc: mt6397: fix alarm register overwrite From: Eddie Huang To: Hsin-Hsiung Wang CC: Lee Jones , Rob Herring , Matthias Brugger , Mark Brown , Marc Zyngier , srv_heupstream , "linux-mediatek@lists.infradead.org" , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Liam Girdwood , "Mark Rutland" , Sean Wang , Alessandro Zummo , Alexandre Belloni , Ran Bi =?UTF-8?Q?=28=E6=AF=95=E5=86=89=29?= Date: Mon, 11 Mar 2019 14:05:02 +0800 In-Reply-To: <1552275991-34648-9-git-send-email-hsin-hsiung.wang@mediatek.com> References: <1552275991-34648-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1552275991-34648-9-git-send-email-hsin-hsiung.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: 2F95C3DC0626900E3474B178BD1D9567E4A8BEB8CDC8C2FFDE03DD70E9CAD2162000:8 X-MTK: N Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Mon, 2019-03-11 at 11:46 +0800, Hsin-Hsiung Wang wrote: > From: Ran Bi > > Alarm registers high byte was reserved for other functions. > This add mask in alarm registers operation functions. > This also fix error condition in interrupt handler. > > Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver") > > Signed-off-by: Ran Bi > --- > drivers/rtc/rtc-mt6397.c | 47 +++++++++++++++++++++++++++++++++-------------- > 1 file changed, 33 insertions(+), 14 deletions(-) > Thanks your interrupt and race condition fix Acked-by: Eddie Huang