From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8C6C28CC5 for ; Sat, 8 Jun 2019 10:19:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C80E212F5 for ; Sat, 8 Jun 2019 10:19:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="A1Tf+oKf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726777AbfFHKTw (ORCPT ); Sat, 8 Jun 2019 06:19:52 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:49572 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbfFHKTw (ORCPT ); Sat, 8 Jun 2019 06:19:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1559989187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8NE8iJ1tXNtCj76fVN4fK098gqqNEc6CFVlZPcPldXE=; b=A1Tf+oKfHq5/Uxxno7gNPEu3ldLB+2ACNj3cbPZ6vJxF4HAFfkq3IcbGAf9HGqyQP+dMTo xZt17uQESHRZjmCsk7gx6hsjnLPkWt0/9G8ut6FF6vfoFMAYg6HwZ4q69n3wnNBudtC0aX x9Wgv5fqlRojyp2ZH3h1o/6kE49GjAM= Date: Sat, 08 Jun 2019 12:19:42 +0200 From: Paul Cercueil Subject: Re: [PATCH] rtc: jz4740: Make probe function __init_or_module To: Alessandro Zummo , Alexandre Belloni Cc: od@zcrc.me, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <1559989182.1815.3@crapouillou.net> In-Reply-To: <20190607155438.14342-1-paul@crapouillou.net> References: <20190607155438.14342-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org I misunderstood what __init_or_module was for. Please ignore this patch. Le ven. 7 juin 2019 =E0 17:54, Paul Cercueil a=20 =E9crit : > This allows the probe function to be dropped after the kernel finished > its initialization, in the case where the driver was not compiled as a > module. >=20 > Signed-off-by: Paul Cercueil > --- > drivers/rtc/rtc-jz4740.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c > index 9e7b3a04debc..a20e7dc794dd 100644 > --- a/drivers/rtc/rtc-jz4740.c > +++ b/drivers/rtc/rtc-jz4740.c > @@ -303,7 +303,7 @@ static const struct of_device_id=20 > jz4740_rtc_of_match[] =3D { > }; > MODULE_DEVICE_TABLE(of, jz4740_rtc_of_match); >=20 > -static int jz4740_rtc_probe(struct platform_device *pdev) > +static int __init_or_module jz4740_rtc_probe(struct platform_device=20 > *pdev) > { > int ret; > struct jz4740_rtc *rtc; > -- > 2.21.0.593.g511ec345e18 >=20 =