From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation
Date: Tue, 25 Feb 2025 18:26:36 +0100 [thread overview]
Message-ID: <171c5e1c-5526-4846-aa50-fe2d49fb7f7f@kernel.org> (raw)
In-Reply-To: <20250225171623302b7862@mail.local>
On 25/02/2025 18:16, Alexandre Belloni wrote:
> On 25/02/2025 18:12:10+0100, Krzysztof Kozlowski wrote:
>> On 25/02/2025 17:34, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Building with W=1 shows a warning about ftm_imx_acpi_ids being unused when
>>> CONFIG_ACPI is disabled:
>>>
>>> drivers/rtc/rtc-fsl-ftm-alarm.c:312:36: error: unused variable 'ftm_imx_acpi_ids' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> I already sent a fix for this few days ago:
>>
>> https://lore.kernel.org/all/20250222114146.162835-1-krzysztof.kozlowski@linaro.org/
>>
>
> But wouldn't Arnd's one be better?
ACPI table can be here entirely dropped and driver will match via
PRP0001, so I think ACPI_PTR makes sense.
But if you have arguments for keeping both, sure... There was no
response to my trivial patch and multiple people will be wasting same
time on the same issue. So just apply whichever of these, before third
person wastes more time on that warning.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-02-25 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 16:34 [PATCH] rtc: fsl-ftm: remove incorrect ACPI_PTR annotation Arnd Bergmann
2025-02-25 17:12 ` Krzysztof Kozlowski
2025-02-25 17:16 ` Alexandre Belloni
2025-02-25 17:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171c5e1c-5526-4846-aa50-fe2d49fb7f7f@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox