From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: john.stultz@linaro.org, Yongliang Gao <leonylgao@gmail.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
Yongliang Gao <leonylgao@tencent.com>,
Jingqun Li <jingqunli@tencent.com>
Subject: Re: [PATCH] rtc: check if __rtc_read_time was successful in rtc_timer_do_work()
Date: Mon, 11 Nov 2024 23:11:20 +0100 [thread overview]
Message-ID: <173136306889.3322178.5149197946199507685.b4-ty@bootlin.com> (raw)
In-Reply-To: <20241011043153.3788112-1-leonylgao@gmail.com>
On Fri, 11 Oct 2024 12:31:53 +0800, Yongliang Gao wrote:
> If the __rtc_read_time call fails,, the struct rtc_time tm; may contain
> uninitialized data, or an illegal date/time read from the RTC hardware.
>
> When calling rtc_tm_to_ktime later, the result may be a very large value
> (possibly KTIME_MAX). If there are periodic timers in rtc->timerqueue,
> they will continually expire, may causing kernel softlockup.
>
> [...]
Applied, thanks!
[1/1] rtc: check if __rtc_read_time was successful in rtc_timer_do_work()
https://git.kernel.org/abelloni/c/e8ba8a2bc4f6
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-11-11 22:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 4:31 [PATCH] rtc: check if __rtc_read_time was successful in rtc_timer_do_work() Yongliang Gao
2024-11-11 22:11 ` Alexandre Belloni [this message]
2024-11-20 14:32 ` Yongliang Gao
[not found] ` <CAJxhyqC9hYo3E=J--EYN9uYQc6_q67X4F5DSgpMFzsWrFcbw4Q@mail.gmail.com>
2024-11-29 23:20 ` Alexandre Belloni
2024-12-02 3:10 ` Yongliang Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173136306889.3322178.5149197946199507685.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=jingqunli@tencent.com \
--cc=john.stultz@linaro.org \
--cc=leonylgao@gmail.com \
--cc=leonylgao@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox