Linux RTC
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Matti Vaittinen <matti.vaittinen@linux.dev>
Cc: Linus Walleij <linusw@kernel.org>,
	Brian Masney <bmasney@redhat.com>,
	 linux-kernel@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	 Matti Vaittinen <mazziesaccount@gmail.com>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	 Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	 Bartosz Golaszewski <brgl@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	devicetree@vger.kernel.org,  linux-gpio@vger.kernel.org,
	linux-clk@vger.kernel.org,
	 Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Stephen Boyd <sboyd@kernel.org>, Lee Jones <lee@kernel.org>,
	 Mark Brown <broonie@kernel.org>,
	mfd@lists.linux.dev,  linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 04/10] dt-bindings: mfd: ROHM BD73800 PMIC
Date: Tue, 04 Aug 2026 07:31:32 -0500	[thread overview]
Message-ID: <178584669046.3596669.1414001628924966753.robh@kernel.org> (raw)
In-Reply-To: <74468853a2c82091dfcdb2193c4eaa67f6191e05.1785838585.git.mazziesaccount@gmail.com>


On Tue, 04 Aug 2026 13:21:32 +0300, Matti Vaittinen wrote:
> From: Matti Vaittinen <mazziesaccount@gmail.com>
> 
> The ROHM BD73800 is a power management IC which integrates 8 BUCKs and 4
> LDOs. There is also an ADC and operation amplifier intended for current
> / temperature measurement and accumulation. RTC and 32.768 kHz clock
> gate are also included. The PMIC can be customized via OTP and it has
> options for operating as a main PMIC in multi-PMIC installation. Some
> of the pins can also be used for GPO or GPI (including interrupt support).
> 
> There are also ROHM BD71851 and BD71885 PMICs out there. These are, from
> the SW-perspective, similar to the BD73800. There is only some different
> default values and OTP settings. The driver should be able to handle them
> just fine.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> 
> ---
> Revision history:
> v1 => v2:
>  - Reference commonly used ROHM bindings from a common binding file
>  - Simplify compatible list
>  - Move relevant comments to description so they can be shown in
>    generated human-readable doc.
>  - Allow other clock-output-names besides "bd73800-32k-out"
> ---
>  .../bindings/mfd/rohm,bd73800-pmic.yaml       | 218 ++++++++++++++++++
>  1 file changed, 218 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck1: False schema does not allow {'regulator-name': ['buck1'], 'regulator-min-microvolt': [[800000]], 'regulator-max-microvolt': [[2000000]], 'regulator-always-on': True, 'regulator-ramp-delay': 1250, 'rohm,dvs-run-voltage': 1150000, 'rohm,dvs-suspend-voltage': 950000}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck2: False schema does not allow {'regulator-name': ['buck2'], 'regulator-min-microvolt': [[800000]], 'regulator-max-microvolt': [[2000000]], 'regulator-always-on': True, 'regulator-ramp-delay': 1250, 'rohm,dvs-run-voltage': 1150000, 'rohm,dvs-suspend-voltage': 950000}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck3: False schema does not allow {'regulator-name': ['buck3'], 'regulator-min-microvolt': [[1200000]], 'regulator-max-microvolt': [[2700000]], 'rohm,dvs-run-voltage': 1150000, 'rohm,dvs-idle-voltage': 1100000, 'rohm,dvs-suspend-voltage': 950000, 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck4: False schema does not allow {'regulator-name': ['buck4'], 'regulator-min-microvolt': [[1100000]], 'regulator-max-microvolt': [[1850000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck5: False schema does not allow {'regulator-name': ['buck5'], 'regulator-min-microvolt': [[1800000]], 'regulator-max-microvolt': [[3300000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck6: False schema does not allow {'regulator-name': ['buck6'], 'regulator-min-microvolt': [[1800000]], 'regulator-max-microvolt': [[3300000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck7: False schema does not allow {'regulator-name': ['buck7'], 'regulator-min-microvolt': [[1800000]], 'regulator-max-microvolt': [[3300000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:buck8: False schema does not allow {'regulator-name': ['buck8'], 'regulator-min-microvolt': [[500000]], 'regulator-max-microvolt': [[1300000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:ldo1: False schema does not allow {'regulator-name': ['ldo1'], 'rohm,ldo-range-high': True, 'regulator-min-microvolt': [[800000]], 'regulator-max-microvolt': [[3300000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:ldo2: False schema does not allow {'regulator-name': ['ldo2'], 'regulator-min-microvolt': [[800000]], 'regulator-max-microvolt': [[3300000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:ldo3: False schema does not allow {'regulator-name': ['ldo3'], 'regulator-min-microvolt': [[800000]], 'regulator-max-microvolt': [[3300000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.example.dtb: pmic@4b (rohm,bd73800): regulators:ldo4: False schema does not allow {'regulator-name': ['ldo4'], 'regulator-min-microvolt': [[650000]], 'regulator-max-microvolt': [[1750000]], 'regulator-always-on': True}
	from schema $id: http://devicetree.org/schemas/mfd/rohm,bd73800-pmic.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/74468853a2c82091dfcdb2193c4eaa67f6191e05.1785838585.git.mazziesaccount@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2026-08-04 12:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 10:19 [PATCH v2 00/10] Support ROHM BD73800 Matti Vaittinen
2026-08-04 10:20 ` [PATCH v2 01/10] dt-bindings: mfd: common ROHM PMIC properties Matti Vaittinen
2026-08-04 10:20 ` [PATCH v2 02/10] dt-bindings: rohm,bd*: Ref common ROHM bindings Matti Vaittinen
2026-08-04 10:21 ` [PATCH v2 03/10] dt-bindings: regulator: ROHM BD73800 regulators Matti Vaittinen
2026-08-04 12:31   ` Rob Herring (Arm)
2026-08-04 10:21 ` [PATCH v2 04/10] dt-bindings: mfd: ROHM BD73800 PMIC Matti Vaittinen
2026-08-04 12:31   ` Rob Herring (Arm) [this message]
2026-08-04 10:21 ` [PATCH v2 05/10] mfd: Support for ROHM BD73800 PMIC core Matti Vaittinen
2026-08-04 10:22 ` [PATCH v2 07/10] regulator: bd71828: Support ROHM BD73800 Matti Vaittinen
2026-08-04 16:56   ` Mark Brown
2026-08-04 10:23 ` [PATCH v2 08/10] clk: bd718x7: " Matti Vaittinen
2026-08-04 10:23 ` [PATCH v2 09/10] gpio: bd73800: Support ROHM BD73800 PMIC GPIOs Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178584669046.3596669.1414001628924966753.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bmasney@redhat.com \
    --cc=brgl@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=matti.vaittinen@linux.dev \
    --cc=mazziesaccount@gmail.com \
    --cc=mfd@lists.linux.dev \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox