From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk. [2a00:1098:0:82:1000:25:2eeb:e3e3]) by gmr-mx.google.com with ESMTPS id p144si1092001wme.2.2017.04.03.08.06.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Apr 2017 08:06:13 -0700 (PDT) Subject: [rtc-linux] Re: [PATCH 7/7] mfd: cros_ec: add RTC as mfd subdevice To: Lee Jones References: <20170324174407.25401-1-enric.balletbo@collabora.com> <20170324174407.25401-8-enric.balletbo@collabora.com> <20170403142512.dlipwaocizisyipg@dell> Cc: Jonathan Cameron , Olof Johansson , bleung@chromium.org, martinez.javier@gmail.com, Guenter Roeck , Gwendal Grignou , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Stephen Barber From: Enric Balletbo i Serra Message-ID: <1e60b276-5327-5bbd-15c5-fd5c920e5ba6@collabora.com> Date: Mon, 3 Apr 2017 17:06:10 +0200 MIME-Version: 1.0 In-Reply-To: <20170403142512.dlipwaocizisyipg@dell> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 03/04/17 16:25, Lee Jones wrote: > On Fri, 24 Mar 2017, Enric Balletbo i Serra wrote: > >> From: Stephen Barber >> >> If the EC supports RTC host commands, expose an RTC device. >> >> Signed-off-by: Stephen Barber >> Signed-off-by: Enric Balletbo i Serra >> --- >> drivers/mfd/cros_ec.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c >> index bbc17ab..1ff88b1 100644 >> --- a/drivers/mfd/cros_ec.c >> +++ b/drivers/mfd/cros_ec.c >> @@ -51,6 +51,11 @@ static const struct mfd_cell ec_pd_cell = { >> .pdata_size = sizeof(pd_p), >> }; >> >> +static const struct mfd_cell ec_rtc_cell = { >> + .name = "cros-ec-rtc", >> + .id = -1, > > Why -1? > >> +}; >> + >> static irqreturn_t ec_irq_thread(int irq, void *data) >> { >> struct cros_ec_device *ec_dev = data; >> @@ -238,6 +243,15 @@ static void cros_ec_sensors_register(struct cros_ec_device *ec_dev) >> kfree(msg); >> } >> >> +static void cros_ec_rtc_register(struct cros_ec_device *ec_dev) >> +{ >> + int ret; >> + >> + ret = mfd_add_devices(ec_dev->dev, 0, &ec_rtc_cell, 1, NULL, 0, NULL); > > Why 0? > Right, just maintained the one in the original. I think I can use PLATFORM_DEVID_AUTO here? >> + if (ret) >> + dev_err(ec_dev->dev, "failed to add EC RTC\n"); >> +} >> + >> int cros_ec_register(struct cros_ec_device *ec_dev) >> { >> struct device *dev = ec_dev->dev; >> @@ -287,6 +301,10 @@ int cros_ec_register(struct cros_ec_device *ec_dev) >> if (cros_ec_check_features(ec_dev, EC_FEATURE_MOTION_SENSE)) >> cros_ec_sensors_register(ec_dev); >> >> + /* Check whether this EC has RTC support */ >> + if (cros_ec_check_features(ec_dev, EC_FEATURE_RTC)) >> + cros_ec_rtc_register(ec_dev); >> + >> if (ec_dev->max_passthru) { >> /* >> * Register a PD device as well on top of this device. > -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.