From: Andrew Morton <akpm@linux-foundation.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Philippe De Muyter <phdm@macqel.be>
Subject: Re: [PATCH v2] rtc: add Abracon ABx80x driver
Date: Tue, 3 Mar 2015 12:20:12 -0800 [thread overview]
Message-ID: <20150303122012.177eee47ba703bd73780b741@linux-foundation.org> (raw)
In-Reply-To: <20150303011116.GW4094@piout.net>
On Tue, 3 Mar 2015 02:11:16 +0100 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> On 02/03/2015 at 15:53:37 -0800, Andrew Morton wrote :
> > On Sun, 1 Mar 2015 11:27:15 +0100 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> >
> > > Add support for the i2c RTC from Abracon.
> >
> > What is the relationship between this patch and
> > http://ozlabs.org/~akpm/mmots/broken-out/rtc-add-rtc-abx805-a-driver-for-the-abracon-ab-1805-i2c-rtc.patch?
> >
>
> I'd say drop mine, I couldn't find the other one before writing it...
>
> I'll try to build on Philippe's driver.
Which driver supports the most devices? Your driver has
+static const struct i2c_device_id abx80x_id[] = {
+ { "abx80x", ABX80X },
+ { "ab0801", AB0801 },
+ { "ab0802", AB0802 },
+ { "ab0803", AB0803 },
+ { "ab0804", AB0804 },
+ { "ab0805", AB0805 },
+ { "ab1801", AB1801 },
+ { "ab1802", AB1802 },
+ { "ab1803", AB1803 },
+ { "ab1804", AB1804 },
+ { "ab1805", AB1805 },
+ { }
+};
And Philippe's has
+static struct i2c_device_id abx805_id[] = {
+ { "abx805-rtc", 0 },
+ { }
+};
And is the naming in Philippe's driver appropriate? If it supports the
AB1801 (for example) then why is it described as an "abx805" driver?
next prev parent reply other threads:[~2015-03-03 20:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 10:27 [PATCH v2] rtc: add Abracon ABx80x driver Alexandre Belloni
2015-03-02 8:54 ` Paul Bolle
2015-03-02 23:53 ` Andrew Morton
2015-03-03 1:11 ` Alexandre Belloni
2015-03-03 20:20 ` Andrew Morton [this message]
2015-03-03 20:50 ` Alexandre Belloni
2015-03-03 22:32 ` Andrew Morton
2015-03-03 23:09 ` Alexandre Belloni
2015-03-04 8:52 ` Philippe De Muyter
2015-03-04 9:06 ` Alexandre Belloni
2015-03-04 9:55 ` Philippe De Muyter
2015-03-04 10:38 ` Alexandre Belloni
2015-03-04 11:43 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303122012.177eee47ba703bd73780b741@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phdm@macqel.be \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox