From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v2 1/2] rtc: interface: Fix coding style violations
Date: Sun, 3 May 2015 12:02:44 +0200 [thread overview]
Message-ID: <20150503100244.GT12076@piout.net> (raw)
In-Reply-To: <1430647031-13584-1-git-send-email-k.kozlowski.k@gmail.com>
On 03/05/2015 at 18:57:10 +0900, Krzysztof Kozlowski wrote :
> Fix issues reported by checkpatch:
> ERROR: open brace '{' following struct go on the same line
> ERROR: "foo* bar" should be "foo *bar"
> Additionally adjust alignment of wrapper function arguments.
I did s/wrapper/wrapped/ and applied, thanks
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>
> ---
>
> Changes since v1:
> 1. Adjust alignment (suggested by Alexandre Belloni).
> ---
> include/linux/rtc.h | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/rtc.h b/include/linux/rtc.h
> index c8b68741994e..4a5e2bda4358 100644
> --- a/include/linux/rtc.h
> +++ b/include/linux/rtc.h
> @@ -101,8 +101,7 @@ struct rtc_timer {
> /* flags */
> #define RTC_DEV_BUSY 0
>
> -struct rtc_device
> -{
> +struct rtc_device {
> struct device dev;
> struct module *owner;
>
> @@ -202,10 +201,10 @@ int rtc_register(rtc_task_t *task);
> int rtc_unregister(rtc_task_t *task);
> int rtc_control(rtc_task_t *t, unsigned int cmd, unsigned long arg);
>
> -void rtc_timer_init(struct rtc_timer *timer, void (*f)(void* p), void* data);
> -int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer* timer,
> - ktime_t expires, ktime_t period);
> -int rtc_timer_cancel(struct rtc_device *rtc, struct rtc_timer* timer);
> +void rtc_timer_init(struct rtc_timer *timer, void (*f)(void *p), void *data);
> +int rtc_timer_start(struct rtc_device *rtc, struct rtc_timer *timer,
> + ktime_t expires, ktime_t period);
> +int rtc_timer_cancel(struct rtc_device *rtc, struct rtc_timer *timer);
> void rtc_timer_do_work(struct work_struct *work);
>
> static inline bool is_leap_year(unsigned int year)
> --
> 2.1.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2015-05-03 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 9:57 [rtc-linux] [PATCH v2 1/2] rtc: interface: Fix coding style violations Krzysztof Kozlowski
2015-05-03 9:57 ` [rtc-linux] [PATCH v2 2/2] rtc: interface: Remove unused return value from rtc_timer_cancel() Krzysztof Kozlowski
2015-05-03 10:03 ` [rtc-linux] " Alexandre Belloni
2015-05-03 10:02 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150503100244.GT12076@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=k.kozlowski.k@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox