From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com. [209.85.212.170]) by gmr-mx.google.com with ESMTPS id gt9si247809wib.2.2015.05.07.23.49.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2015 23:49:21 -0700 (PDT) Received: by widdi4 with SMTP id di4so18056926wid.0 for ; Thu, 07 May 2015 23:49:21 -0700 (PDT) Date: Fri, 8 May 2015 07:49:18 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@stlinux.com, rtc-linux@googlegroups.com, a.zummo@towertech.it, daniel.lezcano@linaro.org, wim@iguana.be, tglx@linutronix.de, linux@roeck-us.net, linux-watchdog@vger.kernel.org Subject: [rtc-linux] Re: [STLinux Kernel] [PATCH 06/12] watchdog: bindings: Supply knowledge of a third supported device - clocksource Message-ID: <20150508064918.GF16220@x1> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-7-git-send-email-lee.jones@linaro.org> <20150507141805.GC9793@griffinp-ThinkPad-X1-Carbon-2nd> <20150507191909.GC16220@x1> <20150507195529.GA28554@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20150507195529.GA28554@griffinp-ThinkPad-X1-Carbon-2nd> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Thu, 07 May 2015, Peter Griffin wrote: > Hi Lee, >=20 > On Thu, 07 May 2015, Lee Jones wrote: >=20 > >=20 > > > > Required properties > > > > =20 > > > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > > > > - "st,stih415-lpc" "st,stid127-lpc" > > > > +- compatible : Must be one of: "st,stih407-lpc" > > >=20 > > > The same comment as the RTC DT patch, you are removing the compatible= s > > > documentation for the other supported platforms like stih416-lpc. > > > AFAIK they are required in the driver to get the correct sysconfig re= gister. > >=20 > > That's intentional. I haven't yet tested any of this IP on > > STiH41{5,6} & STiH127. Due to lack of documentation, I'm not even > > sure if this IP even exists on some of the other platforms. I will > > add them back when support is added to both driver and DTB and I've > > been able to test them. >=20 > That was kind of my point, the driver code AFAIK already contains support > for these SoC's. >=20 > I would either expect the patch to remove support from the DT docs AND th= e > driver, or leave it as is. >=20 > It seems odd to only change the DT docs, and become unaligned to the > code (this assumes I'm looking at the latest patchset here=20 > https://lkml.org/lkml/2015/3/4/1088 which includes support for these SoCs= ). The decision to remove these 'supported' platforms was made on the RTC side, where there is only support for "st,stih407-lpc" in the driver. I thought it best to mirror that thought over to the Watchdog LPC bindings, but thought it not really worth ripping out existing support from the driver. If others wish to test/use the Watchdog on other platforms and can read C code, they'll know what to do. Hopefully all of this will be a non-issue anyway, as I plan to test this on the other boards I have in my farm and make the necessary changes in the upcoming weeks. All should be squared away by the next merge-window. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.