From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id p12si238149wiv.1.2015.05.10.03.31.08 for ; Sun, 10 May 2015 03:31:08 -0700 (PDT) Date: Sun, 10 May 2015 12:31:07 +0200 From: Alexandre Belloni To: Robert Jarzmik Cc: Rob Herring , Russell King , Alessandro Zummo , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Eric Miao , rtc-linux@googlegroups.com Subject: Re: [rtc-linux] Re: [PATCH v2 2/4] rtc: sa1100: convert to run-time register mapping Message-ID: <20150510103107.GH3338@piout.net> References: <1430426233-7461-1-git-send-email-robh@kernel.org> <1430426233-7461-3-git-send-email-robh@kernel.org> <87mw1ojmwz.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <87mw1ojmwz.fsf@belgarion.home> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 01/05/2015 at 18:13:48 +0200, Robert Jarzmik wrote : > Rob Herring writes: > > > static int sa1100_rtc_read_time(struct device *dev, struct rtc_time *tm) > > { > > - rtc_time_to_tm(RCNR, tm); > > + struct sa1100_rtc *info = dev_get_drvdata(dev); > > + rtc_time_to_tm(readl_relaxed(info->rcnr), tm); > One nitpick here : an empty line between info declaration and code would be > better.. > > > @@ -206,8 +215,9 @@ out: > > > > static int sa1100_rtc_proc(struct device *dev, struct seq_file *seq) > > { > > - seq_printf(seq, "trim/divider\t\t: 0x%08x\n", (u32) RTTR); > > - seq_printf(seq, "RTSR\t\t\t: 0x%08x\n", (u32)RTSR); > > + struct sa1100_rtc *info = dev_get_drvdata(dev); > > + seq_printf(seq, "trim/divider\t\t: 0x%08x\n", readl_relaxed(info->rttr)); > > + seq_printf(seq, "RTSR\t\t\t: 0x%08x\n", readl_relaxed(info->rtsr)); > Ditto. > > > @@ -244,6 +256,26 @@ static int sa1100_rtc_probe(struct platform_device *pdev) > > } > > info->irq_1hz = irq_1hz; > > info->irq_alarm = irq_alarm; > > + > > + > Ah here the is one too much. Too bad I had not caught it the first time. > Those are actually reported by checkpatch --strict -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.