From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: rnd4@dave-tech.it
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, Andrea Scian <andrea.scian@dave.eu>
Subject: Re: [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code when reading date/time
Date: Mon, 20 Jul 2015 00:00:48 +0200 [thread overview]
Message-ID: <20150719220048.GA15539@piout.net> (raw)
In-Reply-To: <1434447319-23007-1-git-send-email-rnd4@dave-tech.it>
On 16/06/2015 at 11:35:19 +0200, rnd4@dave-tech.it wrote :
> From: Andrea Scian <andrea.scian@dave.eu>
>
> There's a wrong commend in some RTC driver that say it's better to ignore
> rtc_valid_tm() when reading RTC timestamp. However this is wrong and is
> better to return to the userspace the an error if timestamp is not valid.
>
> Signed-off-by: Andrea Scian <andrea.scian@dave.eu>
> ---
> drivers/rtc/rtc-isl12022.c | 7 +------
> drivers/rtc/rtc-pcf2123.c | 8 +-------
> drivers/rtc/rtc-pcf2127.c | 8 +-------
> drivers/rtc/rtc-pcf8563.c | 8 +-------
> 4 files changed, 4 insertions(+), 27 deletions(-)
>
Applied, after dropping the pcf8563 part as it was part of another
patch.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-07-19 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 8:17 [rtc-linux] [PATCH] driver: rtc: pcf2127: use OFS flag to detect unreliable date and warn the user rnd4
2015-06-08 15:42 ` Alexandre Belloni
2015-06-10 15:21 ` Andrea Scian
2015-06-12 7:42 ` Alexandre Belloni
2015-06-15 15:57 ` Andrea Scian
2015-06-16 9:35 ` [rtc-linux] [PATCH] driver: rtc: use rtc_valid_tm() error code when reading date/time rnd4
2015-07-19 22:00 ` Alexandre Belloni [this message]
2015-06-16 9:39 ` [rtc-linux] [PATCH v2] driver: rtc: pcf2127: use OFS flag to detect unreliable date and warn the user rnd4
2015-07-19 22:03 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150719220048.GA15539@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=andrea.scian@dave.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=rnd4@dave-tech.it \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox