From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id gt9si152058wib.2.2015.07.22.15.05.31 for ; Wed, 22 Jul 2015 15:05:31 -0700 (PDT) Date: Thu, 23 Jul 2015 00:05:29 +0200 From: Alexandre Belloni To: Roosen Henri Cc: "rtc-linux@googlegroups.com" , "a.zummo@towertech.it" Subject: [rtc-linux] Re: [PATCH] rtc: rtc-rx8025: remove obsolete local_irq_disable() and local_irq_enable() for rtc_update_irq() Message-ID: <20150722220529.GQ2853@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi, Seems good to me, I had a similar cleanup that I didn't send yet. do you have an rx8025? I have more cleanups and I can't test them. On 21/07/2015 at 07:11:02 +0000, Roosen Henri wrote : > From b68f4bd992a6bf538edb860662be3178394f8bf5 Mon Sep 17 00:00:00 2001 > From: Henri Roosen > Date: Thu, 16 Jul 2015 10:16:41 +0200 > Subject: [PATCH] rtc: rtc-rx8025: remove obsolete local_irq_disable() and > local_irq_enable() for rtc_update_irq() > > Since commit e6229bec25be4ba00f31dd26e25721cc96c22262 rtc_update_irq() > is callable with irqs enabled. > This triggers a checkpatch warning: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 0123456789ab ("commit description")' #14: Since commit e6229bec25be4ba00f31dd26e25721cc96c22262 rtc_update_irq() > Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com> > --- > drivers/rtc/rtc-rx8025.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c > index e6298e0..9be9c37 100644 > --- a/drivers/rtc/rtc-rx8025.c > +++ b/drivers/rtc/rtc-rx8025.c > @@ -161,9 +161,7 @@ static void rx8025_work(struct work_struct *work) > if (status & RX8025_BIT_CTRL2_CTFG) { > /* periodic */ > status &= ~RX8025_BIT_CTRL2_CTFG; > - local_irq_disable(); > rtc_update_irq(rx8025->rtc, 1, RTC_PF | RTC_IRQF); > - local_irq_enable(); > } > > if (status & RX8025_BIT_CTRL2_DAFG) { > @@ -172,9 +170,7 @@ static void rx8025_work(struct work_struct *work) > if (rx8025_write_reg(client, RX8025_REG_CTRL1, > rx8025->ctrl1 & ~RX8025_BIT_CTRL1_DALE)) > goto out; > - local_irq_disable(); > rtc_update_irq(rx8025->rtc, 1, RTC_AF | RTC_IRQF); > - local_irq_enable(); > } > > /* acknowledge IRQ */ Unfortunately, your patch doesn't apply because the identation has ben mangled, probably by your mailer (tabs became spaces). Can you resend? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.