From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
kernel@pengutronix.de
Subject: Re: [PATCH] rtc: rtctest: enabling UIE for a chip that doesn't support it returns EINVAL
Date: Sat, 3 Oct 2015 14:25:40 +0200 [thread overview]
Message-ID: <20151003122540.GE10444@piout.net> (raw)
In-Reply-To: <1442387811-5384-1-git-send-email-u.kleine-koenig@pengutronix.de>
On 16/09/2015 at 09:16:51 +0200, Uwe Kleine-König wrote :
> Calling ioctl(..., RTC_UIE_ON, ...) without CONFIG_RTC_INTF_DEV_UIE_EMUL
> either ends in rtc_update_irq_enable if rtc->uie_unsupported is true
> or in __rtc_set_alarm in the if (!rtc->ops->set_alarm) branch. In both
> cases the return value is -EINVAL. So check for that one instead of
> ENOTTY.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> tools/testing/selftests/timers/rtctest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-10-03 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 7:15 [rtc-linux] rtctest woes Uwe Kleine-König
2015-09-16 7:16 ` [PATCH] rtc: rtctest: enabling UIE for a chip that doesn't support it returns EINVAL Uwe Kleine-König
2015-10-03 12:25 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003122540.GE10444@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=kernel@pengutronix.de \
--cc=rtc-linux@googlegroups.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox