From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTPS id 190si416401pfb.1.2016.01.26.17.20.36 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 26 Jan 2016 17:20:36 -0800 (PST) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O1L02ZFK7QB3LA0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Wed, 27 Jan 2016 10:20:35 +0900 (KST) Date: Wed, 27 Jan 2016 10:20:34 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Laxman Dewangan , linux-samsung-soc@vger.kernel.org Subject: [rtc-linux] Re: [PATCH v3 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Message-id: <20160127012034.GB14296@samsunx.samsung> References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-3-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 In-reply-to: <1453836020-29579-3-git-send-email-javier@osg.samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tue, Jan 26, 2016 at 04:20:12PM -0300, Javier Martinez Canillas wrote: > It is better to use the ARRAY_SIZE() macro instead of the array length > to avoid bugs if the array is later changed and the length not updated. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski Reviewed-by: Andi Shyti > --- > > Changes in v3: > - Add Krzysztof Kozlowski's Tested-by tag to patch #2. > - Add Laxman Dewangan's Acked-by tag to patch #2. > - Use ARRAY_SIZE() in all places. Suggested by Laxman Dewangan. > > Changes in v2: > - Add Krzysztof Kozlowski's Reviewed-by tag to patch #2. > > drivers/rtc/rtc-max77686.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index 6653c3d11b66..d84a50c9f7f7 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -149,7 +149,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm) > goto out; > > ret = regmap_bulk_read(info->max77686->rtc_regmap, > - MAX77686_RTC_SEC, data, RTC_NR_TIME); > + MAX77686_RTC_SEC, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s: fail to read time reg(%d)\n", __func__, ret); > goto out; > @@ -177,7 +177,7 @@ static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm) > mutex_lock(&info->lock); > > ret = regmap_bulk_write(info->max77686->rtc_regmap, > - MAX77686_RTC_SEC, data, RTC_NR_TIME); > + MAX77686_RTC_SEC, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s: fail to write time reg(%d)\n", __func__, > ret); > @@ -205,7 +205,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > goto out; > > ret = regmap_bulk_read(info->max77686->rtc_regmap, > - MAX77686_ALARM1_SEC, data, RTC_NR_TIME); > + MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s:%d fail to read alarm reg(%d)\n", > __func__, __LINE__, ret); > @@ -215,7 +215,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > max77686_rtc_data_to_tm(data, &alrm->time, info->rtc_24hr_mode); > > alrm->enabled = 0; > - for (i = 0; i < RTC_NR_TIME; i++) { > + for (i = 0; i < ARRAY_SIZE(data); i++) { > if (data[i] & ALARM_ENABLE_MASK) { > alrm->enabled = 1; > break; > @@ -252,7 +252,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > goto out; > > ret = regmap_bulk_read(info->max77686->rtc_regmap, > - MAX77686_ALARM1_SEC, data, RTC_NR_TIME); > + MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", > __func__, ret); > @@ -261,11 +261,11 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > > max77686_rtc_data_to_tm(data, &tm, info->rtc_24hr_mode); > > - for (i = 0; i < RTC_NR_TIME; i++) > + for (i = 0; i < ARRAY_SIZE(data); i++) > data[i] &= ~ALARM_ENABLE_MASK; > > ret = regmap_bulk_write(info->max77686->rtc_regmap, > - MAX77686_ALARM1_SEC, data, RTC_NR_TIME); > + MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > __func__, ret); > @@ -291,7 +291,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) > goto out; > > ret = regmap_bulk_read(info->max77686->rtc_regmap, > - MAX77686_ALARM1_SEC, data, RTC_NR_TIME); > + MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", > __func__, ret); > @@ -312,7 +312,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) > data[RTC_DATE] |= (1 << ALARM_ENABLE_SHIFT); > > ret = regmap_bulk_write(info->max77686->rtc_regmap, > - MAX77686_ALARM1_SEC, data, RTC_NR_TIME); > + MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > __func__, ret); > @@ -341,7 +341,7 @@ static int max77686_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) > goto out; > > ret = regmap_bulk_write(info->max77686->rtc_regmap, > - MAX77686_ALARM1_SEC, data, RTC_NR_TIME); > + MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data)); > > if (ret < 0) { > dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > @@ -406,7 +406,8 @@ static int max77686_rtc_init_reg(struct max77686_rtc_info *info) > > info->rtc_24hr_mode = 1; > > - ret = regmap_bulk_write(info->max77686->rtc_regmap, MAX77686_RTC_CONTROLM, data, 2); > + ret = regmap_bulk_write(info->max77686->rtc_regmap, > + MAX77686_RTC_CONTROLM, data, ARRAY_SIZE(data)); > if (ret < 0) { > dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", > __func__, ret); > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.