[rtc-linux] Re: [PATCH v4 2/2] rtc: add driver for RX6110SA real time clock

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

On 04/01/2016 at 18:04:35 +0100, Steffen Trumtrar wrote :
> The RX6110 comes in two different variants: SPI and I2C.
> This driver only supports the SPI variant.
> 
> If the need ever arises to also support the I2C variant, this driver
> could easily be refactored to support both cases.
> 
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> 
> Changes since v3:
>     - remove old copyright infos
>     - use the BIT() macro
>     - replace rx6110_get_week_day() with ffs()
>     - replace hardcoded offsets with enum
>     - use regmap_bulk_write in set_time
>     - use regmap_register_patch in init function
>     - return -EINVAL instead of "fixing" time in the rtc
> 
>  drivers/rtc/Kconfig      |   9 ++
>  drivers/rtc/Makefile     |   1 +
>  drivers/rtc/rtc-rx6110.c | 402 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 412 insertions(+)
>  create mode 100644 drivers/rtc/rtc-rx6110.c
> 
Applied, after realigning some lines in rx6110_probe().

Thanks!

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.