[rtc-linux] Re: [PATCH v4 2/7] rtc: merge ds3232 and ds3234

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

On 07/03/2016 at 00:27:48 +0900, Akinobu Mita wrote :
> According to "Feature Comparison of the DS323x Real-Time Clocks"
> (http://pdfserv.maximintegrated.com/en/an/AN5143.pdf), DS3232 and
> DS3234 are very similar.
> 
> This merges rtc-ds3232 and rtc-ds3234 with using regmap.
> This change also enables to support alarm for ds3234.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Suggested-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Dennis Aberilla <denzzzhome@yahoo.com>
> ---
> * v4
> - stop splitting core and i2c modules
> 
>  drivers/rtc/Kconfig      |  42 ++++++------
>  drivers/rtc/Makefile     |   1 -
>  drivers/rtc/rtc-ds3232.c | 167 ++++++++++++++++++++++++++++++++++++++++++++-
>  drivers/rtc/rtc-ds3234.c | 171 -----------------------------------------------
>  4 files changed, 187 insertions(+), 194 deletions(-)
>  delete mode 100644 drivers/rtc/rtc-ds3234.c
> 

I applied it after adding the REGMAP_I2C and REGMAP_SPI selection. I
also fixed the ds323?_unregister_driver prototype (void instead of int)
when I2C or SPI are not selected.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.