From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id 71si253736wmp.0.2016.03.12.07.43.58 for ; Sat, 12 Mar 2016 07:43:58 -0800 (PST) Date: Sat, 12 Mar 2016 16:43:56 +0100 From: Alexandre Belloni To: Akinobu Mita Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Renaud Cerrato Subject: [rtc-linux] Re: [PATCH 1/3] rtc: pcf2127: conver to use regmap Message-ID: <20160312154356.GA2693@piout.net> References: <1457713336-24262-1-git-send-email-akinobu.mita@gmail.com> <20160311181111.GC4620@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 13/03/2016 at 00:39:34 +0900, Akinobu Mita wrote : > The reason is regmap_i2c_read() doesn't work for this device because the > STOP condition is required between set register address and read register > data. (Fig 45. Bus protocol, reading from registers in PCF2127.pdf) > > I'll update this patch by adding that comment. That would be great. You also have a small typo in the subject line. Apart from that, I'm ready to take the patches. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.