From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id c7si44527wmf.2.2016.03.18.16.08.20 for ; Fri, 18 Mar 2016 16:08:20 -0700 (PDT) Date: Sat, 19 Mar 2016 00:08:19 +0100 From: Alexandre Belloni To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Joe Perches , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral Message-ID: <20160318230819.GF2828@piout.net> References: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 14/03/2016 at 22:38:38 -0300, Javier Martinez Canillas wrote : > The clock and source clock looked up by the driver may not be available > just because the clock controller driver was not probed yet so printing > an error in this case is not correct and only adds confusion to users. > > However, knowing that a driver's probe was deferred may be useful so it > can be printed as a debug information. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v3: > - Change debug messages again as suggested by Joe Perches. > > Changes in v2: > - Improve debug messages as suggested by Joe Perches. > > drivers/rtc/rtc-s3c.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.