[rtc-linux] Re: [PATCH] rtc: ds1307: ds3231 temperature s16 overflow

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

On 18/04/2016 at 09:21:42 +0900, Akinobu Mita wrote :
> From: Zhuang Yuyao <mlistz@gmail.com>
> 
> while retrieving temperature from ds3231, the result may be overflow
> since s16 is too small for a multiplication with 250.
> 
> ie. if temp_buf[0] == 0x2d, the result (s16 temp) will be negative.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Zhuang Yuyao <mlistz@gmail.com>
> Cc: Zhuang Yuyao <zhuangyy@syan.com.cn>
> Cc: Michael Tatarinov <kukabu@gmail.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/rtc/rtc-ds1307.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.