[rtc-linux] Re: [PATCH 4/6] rtc: rv3029: Removes some checks and warnings

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

On 23/04/2016 at 01:29:46 +0200, Alexandre Belloni wrote :
> Hi,
>=20
> On 21/04/2016 at 20:24:17 +0200, Myl=C4=8Dne Josserand wrote :
> > @@ -829,8 +829,6 @@ static void rv3029_unregister_driver(void)
> > =20
> >  static int rv3049_probe(struct spi_device *spi)
> >  {
> > -	int res;
> > -	unsigned int tmp;
>=20
> Well, you just introduced those variables in the previous patch.
>=20

And I forgot to add that you still have a few checkpatch warnings to
remove while at it:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#129: FILE: drivers/rtc/rtc-rv3029c2.c:129:
+			    unsigned len)

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
#141: FILE: drivers/rtc/rtc-rv3029c2.c:141:
+			     unsigned len)


--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.