From: Rob Herring <robh@kernel.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options
Date: Sun, 19 Jun 2016 09:29:34 -0500 [thread overview]
Message-ID: <20160619142934.GA8522@rob-hp-laptop> (raw)
In-Reply-To: <1465970379-14703-4-git-send-email-andrew.smirnov@gmail.com>
On Tue, Jun 14, 2016 at 10:59:29PM -0700, Andrey Smirnov wrote:
> Add DS1341 specific power-saving options that allow to disable certain
> functional aspects of the chip in order to minimize its power
> consumption.
This description doesn't match that you are adding a new binding. It is
preferred that bindings are a separate patch.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> .../devicetree/bindings/rtc/dallas,ds1341.txt | 23 ++++++++++++++++++
> drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++
> 2 files changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
> new file mode 100644
> index 0000000..b8be7a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt
> @@ -0,0 +1,23 @@
> +* Dallas DS1341 I2C Serial Real-Time Clock
> +
> +Required properties:
> +
> +- compatible: Should contain "dallas,ds1341".
> +
> +- reg: I2C address for chip
> +
> +Optional properties:
> +
> +- disable-oscillator-stop-flag : Configure chip to disable oscillator
> + fault detection circuitry
> +
> +- enable-glitch-filter : Configure chip to enable crystal oscillator
> + output glitch filtering
What determines setting these properties or not?
They should have vendor prefix and be explicit that they are boolean.
Rob
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-06-19 14:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 5:59 [rtc-linux] [PATCH 00/13] DS1341 support and code cleanup Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 01/13] RTC: ds1307: Add DS1341 variant Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 02/13] RTC: ds1307: Disable square wave and timers as default Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 03/13] RTC: ds1307: Add DS1341 specific power-saving options Andrey Smirnov
2016-06-19 14:29 ` Rob Herring [this message]
2016-06-19 18:12 ` [rtc-linux] " Andrey Smirnov
2016-06-21 20:49 ` Rob Herring
2016-06-21 21:07 ` Alexandre Belloni
2016-06-22 2:34 ` Andrey Smirnov
2016-07-12 16:21 ` Andrey Smirnov
2016-07-19 22:47 ` Alexandre Belloni
2016-07-19 23:56 ` Andrey Smirnov
2016-07-20 9:02 ` Alexandre Belloni
2016-07-20 14:36 ` Andrey Smirnov
2016-07-20 15:38 ` Alexandre Belloni
2016-07-20 16:11 ` Andrey Smirnov
2016-06-21 23:23 ` Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 04/13] RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 05/13] RTC: ds1307: Convert want_irq " Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 06/13] RTC: ds1307: Move chip configuration into a separate routine Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 07/13] RTC: ds1307: Move chip sanity checking " Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 08/13] RTC: ds1307: Remove register "cache" Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 09/13] RTC: ds1307: Constify struct ds1307 where possible Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 10/13] RTC: ds1307: Convert goto to a loop Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 11/13] RTC: ds1307: Redefine RX8025_REG_* to minimize extra code Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 12/13] RTC: ds1307: Report oscillator problems more intelligently Andrey Smirnov
2016-06-15 5:59 ` [rtc-linux] [PATCH 13/13] RTC: ds1307: Move last bits of sanity checking out of chip_configure Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160619142934.GA8522@rob-hp-laptop \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrew.smirnov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox