From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Stephan Roslen <stephan@roslen.de>
Cc: Chen-Yu Tsai <wens@csie.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH] rtc: sunxi: use external oscillator
Date: Thu, 7 Jul 2016 09:08:09 +0200 [thread overview]
Message-ID: <20160707070809.GB5907@lukather> (raw)
In-Reply-To: <577DF2B9.602@roslen.de>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Thu, Jul 07, 2016 at 08:12:09AM +0200, Stephan Roslen wrote:
> > Within the current sunxi clk structure, the LOSC is registered as a fixed
> > 32.768 KHz clk. So this patch actually makes things right.
>
> In this case it should still be addressed somewhere in drivers/clk/sunxi, not
> in drivers/rtc, I guess? Would you prefer setting the external 32.768 KHz crystal
> as hard coded default instead of providing the muxer? It could be considered okay,
> for the data sheet seems to demand presence of the external oscillator and there
> is absolutely no use in a 32KHz +- 20% oscillator, if a 32.768KHz crystal is
> available.
Yes, poking into the registers in drivers/clk would also work.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-07 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 8:43 [rtc-linux] [PATCH] rtc: sunxi: use external oscillator Stephan Roslen
2016-07-06 20:20 ` [rtc-linux] " Maxime Ripard
2016-07-07 4:50 ` Stephan Roslen
2016-07-07 4:53 ` Chen-Yu Tsai
2016-07-07 6:12 ` Stephan Roslen
2016-07-07 7:08 ` Maxime Ripard [this message]
2016-07-07 6:42 ` Maxime Ripard
2016-07-07 5:11 ` Stephan Roslen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707070809.GB5907@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=rtc-linux@googlegroups.com \
--cc=stephan@roslen.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox